From: "Metzger, Markus T" <markus.t.metzger@intel.com>
To: Luis Machado <lgustavo@codesourcery.com>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: RE: [PATCH] btrace: add unsupported/untested messages when skipping tests
Date: Mon, 12 Dec 2016 08:26:00 -0000 [thread overview]
Message-ID: <A78C989F6D9628469189715575E55B2340017610@IRSMSX104.ger.corp.intel.com> (raw)
In-Reply-To: <44ab7b08-e6e3-d949-f8b7-02c830e090f5@codesourcery.com>
> -----Original Message-----
> From: Luis Machado [mailto:lgustavo@codesourcery.com]
> Sent: Friday, December 9, 2016 4:32 PM
> To: Metzger, Markus T <markus.t.metzger@intel.com>; gdb-
> patches@sourceware.org
> Subject: Re: [PATCH] btrace: add unsupported/untested messages when skipping
> tests
Hi Luis,
> In previous reviews it was deemed more appropriate to just say "failed
> to compile", since the source file information could be extracted from
> the testcase itself via the log file.
I don't see why we should not print it. The file name may already help to see a
pattern just from the FAIL messages. Further, if a test is compiling more than one
file, we'd want to see which compilation failed.
Do you have a link where this was discussed?
Thanks,
Markus.
Intel Deutschland GmbH
Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Christin Eisenschmid, Christian Lamprechter
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928
next prev parent reply other threads:[~2016-12-12 8:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-09 13:27 Markus Metzger
2016-12-09 15:32 ` Luis Machado
2016-12-09 19:50 ` Luis Machado
2016-12-12 8:26 ` Metzger, Markus T [this message]
2016-12-23 14:37 ` Luis Machado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A78C989F6D9628469189715575E55B2340017610@IRSMSX104.ger.corp.intel.com \
--to=markus.t.metzger@intel.com \
--cc=gdb-patches@sourceware.org \
--cc=lgustavo@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox