From: Luis Machado <lgustavo@codesourcery.com>
To: "Metzger, Markus T" <markus.t.metzger@intel.com>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH] btrace: add unsupported/untested messages when skipping tests
Date: Fri, 23 Dec 2016 14:37:00 -0000 [thread overview]
Message-ID: <78901e7c-2bf3-01e7-e62a-469062896b0e@codesourcery.com> (raw)
In-Reply-To: <A78C989F6D9628469189715575E55B2340017610@IRSMSX104.ger.corp.intel.com>
On 12/12/2016 02:26 AM, Metzger, Markus T wrote:
>> -----Original Message-----
>> From: Luis Machado [mailto:lgustavo@codesourcery.com]
>> Sent: Friday, December 9, 2016 4:32 PM
>> To: Metzger, Markus T <markus.t.metzger@intel.com>; gdb-
>> patches@sourceware.org
>> Subject: Re: [PATCH] btrace: add unsupported/untested messages when skipping
>> tests
>
> Hi Luis,
>
>
>> In previous reviews it was deemed more appropriate to just say "failed
>> to compile", since the source file information could be extracted from
>> the testcase itself via the log file.
>
> I don't see why we should not print it. The file name may already help to see a
> pattern just from the FAIL messages. Further, if a test is compiling more than one
> file, we'd want to see which compilation failed.
>
> Do you have a link where this was discussed?
Sorry for the late reply, i was out on vacation.
This was briefly discussed here:
https://sourceware.org/ml/gdb-patches/2016-11/msg00826.html
Simon and Pedro thought it would be better to simplify the message so as
not to pollute the summary too much, and in order to have unique names
that don't change between two runs on different machines.
prev parent reply other threads:[~2016-12-23 14:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-09 13:27 Markus Metzger
2016-12-09 15:32 ` Luis Machado
2016-12-09 19:50 ` Luis Machado
2016-12-12 8:26 ` Metzger, Markus T
2016-12-23 14:37 ` Luis Machado [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=78901e7c-2bf3-01e7-e62a-469062896b0e@codesourcery.com \
--to=lgustavo@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=markus.t.metzger@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox