From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 110496 invoked by alias); 23 Dec 2016 14:37:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 110456 invoked by uid 89); 23 Dec 2016 14:37:54 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=Friday, late X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 23 Dec 2016 14:37:44 +0000 Received: from svr-orw-mbx-03.mgc.mentorg.com ([147.34.90.203]) by relay1.mentorg.com with esmtp id 1cKQyc-0000QY-F6 from Luis_Gustavo@mentor.com ; Fri, 23 Dec 2016 06:37:42 -0800 Received: from [172.30.6.17] (147.34.91.1) by svr-orw-mbx-03.mgc.mentorg.com (147.34.90.203) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Fri, 23 Dec 2016 06:37:39 -0800 Reply-To: Luis Machado Subject: Re: [PATCH] btrace: add unsupported/untested messages when skipping tests References: <1481290056-9983-1-git-send-email-markus.t.metzger@intel.com> <44ab7b08-e6e3-d949-f8b7-02c830e090f5@codesourcery.com> To: "Metzger, Markus T" , "gdb-patches@sourceware.org" From: Luis Machado Message-ID: <78901e7c-2bf3-01e7-e62a-469062896b0e@codesourcery.com> Date: Fri, 23 Dec 2016 14:37:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: svr-orw-mbx-03.mgc.mentorg.com (147.34.90.203) To svr-orw-mbx-03.mgc.mentorg.com (147.34.90.203) X-IsSubscribed: yes X-SW-Source: 2016-12/txt/msg00399.txt.bz2 On 12/12/2016 02:26 AM, Metzger, Markus T wrote: >> -----Original Message----- >> From: Luis Machado [mailto:lgustavo@codesourcery.com] >> Sent: Friday, December 9, 2016 4:32 PM >> To: Metzger, Markus T ; gdb- >> patches@sourceware.org >> Subject: Re: [PATCH] btrace: add unsupported/untested messages when skipping >> tests > > Hi Luis, > > >> In previous reviews it was deemed more appropriate to just say "failed >> to compile", since the source file information could be extracted from >> the testcase itself via the log file. > > I don't see why we should not print it. The file name may already help to see a > pattern just from the FAIL messages. Further, if a test is compiling more than one > file, we'd want to see which compilation failed. > > Do you have a link where this was discussed? Sorry for the late reply, i was out on vacation. This was briefly discussed here: https://sourceware.org/ml/gdb-patches/2016-11/msg00826.html Simon and Pedro thought it would be better to simplify the message so as not to pollute the summary too much, and in order to have unique names that don't change between two runs on different machines.