From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23157 invoked by alias); 12 Dec 2016 08:26:43 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 23136 invoked by uid 89); 12 Dec 2016 08:26:42 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-5.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=U*patches, GmbH, Directors, gmbh X-HELO: mga07.intel.com Received: from mga07.intel.com (HELO mga07.intel.com) (134.134.136.100) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 12 Dec 2016 08:26:32 +0000 Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga105.jf.intel.com with ESMTP; 12 Dec 2016 00:26:29 -0800 X-ExtLoop1: 1 Received: from irsmsx103.ger.corp.intel.com ([163.33.3.157]) by FMSMGA003.fm.intel.com with ESMTP; 12 Dec 2016 00:26:22 -0800 Received: from irsmsx104.ger.corp.intel.com ([169.254.5.52]) by IRSMSX103.ger.corp.intel.com ([169.254.3.91]) with mapi id 14.03.0248.002; Mon, 12 Dec 2016 08:26:20 +0000 From: "Metzger, Markus T" To: Luis Machado , "gdb-patches@sourceware.org" Subject: RE: [PATCH] btrace: add unsupported/untested messages when skipping tests Date: Mon, 12 Dec 2016 08:26:00 -0000 Message-ID: References: <1481290056-9983-1-git-send-email-markus.t.metzger@intel.com> <44ab7b08-e6e3-d949-f8b7-02c830e090f5@codesourcery.com> In-Reply-To: <44ab7b08-e6e3-d949-f8b7-02c830e090f5@codesourcery.com> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2016-12/txt/msg00262.txt.bz2 > -----Original Message----- > From: Luis Machado [mailto:lgustavo@codesourcery.com] > Sent: Friday, December 9, 2016 4:32 PM > To: Metzger, Markus T ; gdb- > patches@sourceware.org > Subject: Re: [PATCH] btrace: add unsupported/untested messages when skipp= ing > tests Hi Luis, > In previous reviews it was deemed more appropriate to just say "failed > to compile", since the source file information could be extracted from > the testcase itself via the log file. I don't see why we should not print it. The file name may already help to = see a pattern just from the FAIL messages. Further, if a test is compiling more = than one file, we'd want to see which compilation failed. Do you have a link where this was discussed? Thanks, Markus. Intel Deutschland GmbH Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Christian Lamprechter Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928