From: "Metzger, Markus T" <markus.t.metzger@intel.com>
To: Pedro Alves <palves@redhat.com>
Cc: "jan.kratochvil@redhat.com" <jan.kratochvil@redhat.com>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: RE: [PATCH 2/2] btrace: avoid symbol lookup
Date: Mon, 10 Mar 2014 08:05:00 -0000 [thread overview]
Message-ID: <A78C989F6D9628469189715575E55B230AA881A9@IRSMSX104.ger.corp.intel.com> (raw)
In-Reply-To: <5319EBF6.5090601@redhat.com>
> -----Original Message-----
> From: Pedro Alves [mailto:palves@redhat.com]
> Sent: Friday, March 07, 2014 4:56 PM
Thanks for your review.
> To: Metzger, Markus T
> Cc: jan.kratochvil@redhat.com; gdb-patches@sourceware.org
> Subject: Re: [PATCH 2/2] btrace: avoid symbol lookup
>
> On 03/07/2014 08:57 AM, Markus Metzger wrote:
> > --- a/gdb/testsuite/gdb.btrace/exception.exp
> > +++ b/gdb/testsuite/gdb.btrace/exception.exp
> > @@ -47,7 +47,7 @@ gdb_continue_to_breakpoint "cont to bp.2"
> ".*$srcfile:$bp_2\r\n.*"
> > send_gdb "record function-call-history 1\n"
> > gdb_expect_list "flat" "\r\n$gdb_prompt $" [list \
> > [join [list \
> > - "1\tmain\\(\\)" \
> > + "1\tmain" \
> > "2\ttest\\(\\)" \
> > "3\tfoo\\(\\)" \
> > "4\tbar\\(\\)" \
>
> I wonder whether people will think the different looks are a bug...
>
> Also, doesn't that mean we'll show mangled C++ names? Won't that
> be quite user unfriendly?
It would. Fortunately, GDB already prints the demangled name also for
minimal symbols - see MSYMBOL_PRINT_NAME which calls
symbol_natural_name. Minimal and full symbols seem to be treated the
same way.
This does not work for main, though, for which the minimal symbol has
language 'auto' and the full symbol has language 'cplus'.
Regards,
Markus.
Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen, Deutschland
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk
Registergericht: Muenchen HRB 47456
Ust.-IdNr./VAT Registration No.: DE129385895
Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052
next prev parent reply other threads:[~2014-03-10 8:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-07 8:57 [PATCH 0/2] btrace: perf improvements Markus Metzger
2014-03-07 8:57 ` [PATCH 1/2] btrace: only search for lines in current symtab Markus Metzger
2014-03-21 17:43 ` Jan Kratochvil
2014-03-07 8:57 ` [PATCH 2/2] btrace: avoid symbol lookup Markus Metzger
2014-03-07 15:55 ` Pedro Alves
2014-03-10 8:05 ` Metzger, Markus T [this message]
2014-03-07 15:56 ` Pedro Alves
2014-03-10 21:43 ` Jan Kratochvil
2014-03-11 10:08 ` Metzger, Markus T
2014-03-21 17:22 ` Jan Kratochvil
2014-03-24 7:57 ` Metzger, Markus T
2014-03-24 8:37 ` Jan Kratochvil
2014-03-24 9:21 ` Metzger, Markus T
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A78C989F6D9628469189715575E55B230AA881A9@IRSMSX104.ger.corp.intel.com \
--to=markus.t.metzger@intel.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox