From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28927 invoked by alias); 10 Mar 2014 08:05:52 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 28916 invoked by uid 89); 10 Mar 2014 08:05:52 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=AWL,BAYES_20,KAM_STOCKGEN,SPF_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: mga09.intel.com Received: from mga09.intel.com (HELO mga09.intel.com) (134.134.136.24) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 10 Mar 2014 08:05:48 +0000 Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP; 10 Mar 2014 01:01:17 -0700 X-ExtLoop1: 1 Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153]) by orsmga002.jf.intel.com with ESMTP; 10 Mar 2014 01:05:44 -0700 Received: from irsmsx104.ger.corp.intel.com ([169.254.5.174]) by IRSMSX101.ger.corp.intel.com ([169.254.1.67]) with mapi id 14.03.0123.003; Mon, 10 Mar 2014 08:05:44 +0000 From: "Metzger, Markus T" To: Pedro Alves CC: "jan.kratochvil@redhat.com" , "gdb-patches@sourceware.org" Subject: RE: [PATCH 2/2] btrace: avoid symbol lookup Date: Mon, 10 Mar 2014 08:05:00 -0000 Message-ID: References: <1394182665-14164-1-git-send-email-markus.t.metzger@intel.com> <1394182665-14164-3-git-send-email-markus.t.metzger@intel.com> <5319EBF6.5090601@redhat.com> In-Reply-To: <5319EBF6.5090601@redhat.com> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2014-03/txt/msg00231.txt.bz2 > -----Original Message----- > From: Pedro Alves [mailto:palves@redhat.com] > Sent: Friday, March 07, 2014 4:56 PM Thanks for your review. > To: Metzger, Markus T > Cc: jan.kratochvil@redhat.com; gdb-patches@sourceware.org > Subject: Re: [PATCH 2/2] btrace: avoid symbol lookup >=20 > On 03/07/2014 08:57 AM, Markus Metzger wrote: > > --- a/gdb/testsuite/gdb.btrace/exception.exp > > +++ b/gdb/testsuite/gdb.btrace/exception.exp > > @@ -47,7 +47,7 @@ gdb_continue_to_breakpoint "cont to bp.2" > ".*$srcfile:$bp_2\r\n.*" > > send_gdb "record function-call-history 1\n" > > gdb_expect_list "flat" "\r\n$gdb_prompt $" [list \ > > [join [list \ > > - "1\tmain\\(\\)" \ > > + "1\tmain" \ > > "2\ttest\\(\\)" \ > > "3\tfoo\\(\\)" \ > > "4\tbar\\(\\)" \ >=20 > I wonder whether people will think the different looks are a bug... >=20 > Also, doesn't that mean we'll show mangled C++ names? Won't that > be quite user unfriendly? It would. Fortunately, GDB already prints the demangled name also for minimal symbols - see MSYMBOL_PRINT_NAME which calls symbol_natural_name. Minimal and full symbols seem to be treated the same way. This does not work for main, though, for which the minimal symbol has language 'auto' and the full symbol has language 'cplus'. Regards, Markus. Intel GmbH Dornacher Strasse 1 85622 Feldkirchen/Muenchen, Deutschland Sitz der Gesellschaft: Feldkirchen bei Muenchen Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk Registergericht: Muenchen HRB 47456 Ust.-IdNr./VAT Registration No.: DE129385895 Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052