From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: "Metzger, Markus T" <markus.t.metzger@intel.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
"Pedro Alves (palves@redhat.com)" <palves@redhat.com>
Subject: Re: [PATCH 2/2] btrace: avoid symbol lookup
Date: Fri, 21 Mar 2014 17:22:00 -0000 [thread overview]
Message-ID: <20140321172215.GA15215@host2.jankratochvil.net> (raw)
In-Reply-To: <A78C989F6D9628469189715575E55B230AA8BFE3@IRSMSX104.ger.corp.intel.com>
On Tue, 11 Mar 2014 11:08:43 +0100, Metzger, Markus T wrote:
> What's missing is a "fast fail", i.e. quickly determine that we won't find any
> symbol for this PC. I won't be able to do this in a reasonable amount of time,
> though, so I thought this patch is a compromise between functionality and
> performance.
I do not think providing incorrect behavior for performance reasons is a valid
tradeoff. The right way would be to fix the DWARF lookups to be fast enough.
But I no longer approve GDB patches so this is just my personal opinion.
Jan
next prev parent reply other threads:[~2014-03-21 17:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-07 8:57 [PATCH 0/2] btrace: perf improvements Markus Metzger
2014-03-07 8:57 ` [PATCH 1/2] btrace: only search for lines in current symtab Markus Metzger
2014-03-21 17:43 ` Jan Kratochvil
2014-03-07 8:57 ` [PATCH 2/2] btrace: avoid symbol lookup Markus Metzger
2014-03-07 15:55 ` Pedro Alves
2014-03-10 8:05 ` Metzger, Markus T
2014-03-07 15:56 ` Pedro Alves
2014-03-10 21:43 ` Jan Kratochvil
2014-03-11 10:08 ` Metzger, Markus T
2014-03-21 17:22 ` Jan Kratochvil [this message]
2014-03-24 7:57 ` Metzger, Markus T
2014-03-24 8:37 ` Jan Kratochvil
2014-03-24 9:21 ` Metzger, Markus T
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140321172215.GA15215@host2.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=markus.t.metzger@intel.com \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox