From: "Metzger, Markus T" <markus.t.metzger@intel.com>
To: Doug Evans <dje@google.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
"markus.t.metzger@gmail.com" <markus.t.metzger@gmail.com>,
"jan.kratochvil@redhat.com" <jan.kratochvil@redhat.com>,
"palves@redhat.com" <palves@redhat.com>,
"tromey@redhat.com" <tromey@redhat.com>,
"kettenis@gnu.org" <kettenis@gnu.org>
Subject: RE: [patch v3 01/16] gdbserver, build: add -DGDBSERVER
Date: Wed, 15 Aug 2012 07:59:00 -0000 [thread overview]
Message-ID: <A78C989F6D9628469189715575E55B2307ACFAD7@IRSMSX102.ger.corp.intel.com> (raw)
In-Reply-To: <CADPb22SbJnp0if+qXTKNP+aJ-mTsP9Qgc5nbc6Tidm5v8mkc4A@mail.gmail.com>
> -----Original Message-----
> From: Doug Evans [mailto:dje@google.com]
> Sent: Wednesday, August 15, 2012 2:41 AM
Thanks for your review!
[...]
> > +# Let all files know we're compiling for gdbserver.
> > +INTERNAL_CFLAGS += -DGDBSERVER
[...]
> "+=" is a GNU make-ism, I think we can't use it here.
>
> Plus you missed one:
>
> gdb_vecs.o: ../common/gdb_vecs.c $(vec_h) $(gdb_vecs_h) $(host_defs_h)
> $(CC) -c $(CPPFLAGS) $(INTERNAL_CFLAGS) $< -DGDBSERVER
Fixed both. Gdb/common is growing very fast - that's good. I'll send an updated patch.
Regards,
Markus.
Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen, Deutschland
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Douglas Lusk, Peter Gleissner, Hannes Schwaderer, Christian Lamprechter
Registergericht: Muenchen HRB 47456
Ust.-IdNr./VAT Registration No.: DE129385895
Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052
next prev parent reply other threads:[~2012-08-15 7:59 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-14 13:01 [patch v3 00/16] branch tracing support for Atom markus.t.metzger
2012-08-14 13:00 ` [patch v3 01/16] gdbserver, build: add -DGDBSERVER markus.t.metzger
2012-08-15 0:41 ` Doug Evans
2012-08-15 7:59 ` Metzger, Markus T [this message]
2012-08-14 13:00 ` [patch v3 02/16] disas: add precise instructions flag markus.t.metzger
2012-08-14 13:00 ` [patch v3 10/16] xml, btrace: define btrace xml document style markus.t.metzger
2012-08-14 13:01 ` [patch v3 05/16] thread, btrace: add generic branch trace support markus.t.metzger
2012-08-14 13:01 ` [patch v3 03/16] source: add flags to print_source_lines () markus.t.metzger
2012-09-11 20:14 ` Tom Tromey
2012-09-12 8:34 ` Metzger, Markus T
2012-08-14 13:01 ` [patch v3 07/16] configure: add check for perf_event header markus.t.metzger
2012-08-14 13:01 ` [patch v3 12/16] gdbserver, btrace: add generic btrace support markus.t.metzger
2012-08-14 13:01 ` [patch v3 08/16] linux, btrace: perf_event based branch tracing markus.t.metzger
2012-08-14 13:01 ` [patch v3 11/16] remote, btrace: add branch trace remote ops markus.t.metzger
2012-08-14 13:01 ` [patch v3 13/16] gdbserver, linux, btrace: add btrace support for linux-low markus.t.metzger
2012-08-14 13:01 ` [patch v3 16/16] btrace, x86: restrict to Atom markus.t.metzger
2012-08-14 13:27 ` Mark Kettenis
[not found] ` <A78C989F6D9628469189715575E55B2307ACF558@IRSMSX102.ger.corp.intel.com>
2012-08-14 15:57 ` FW: " Metzger, Markus T
2012-09-24 12:23 ` Metzger, Markus T
2012-09-27 7:08 ` Joel Brobecker
2012-09-28 2:40 ` Mark Kettenis
2012-09-28 6:51 ` Metzger, Markus T
2012-10-01 19:24 ` Mark Kettenis
2012-10-04 7:51 ` Metzger, Markus T
2012-08-14 13:01 ` [patch v3 09/16] linux, i386, amd64: enable btrace for 32bit and 64bit linux native markus.t.metzger
2012-08-14 13:01 ` [patch v3 04/16] source, disasm: optionally prefix source lines with filename markus.t.metzger
2012-09-11 20:21 ` Tom Tromey
2012-08-14 13:03 ` [patch v3 06/16] cli, btrace: add btrace cli markus.t.metzger
2012-08-14 13:03 ` [patch v3 14/16] test, btrace: add branch tracing tests markus.t.metzger
2012-08-14 13:03 ` [patch v3 15/16] test, btrace: more " markus.t.metzger
2012-08-15 7:59 [patch v3 01/16] gdbserver, build: add -DGDBSERVER markus.t.metzger
2012-08-23 14:41 ` Tom Tromey
2012-08-24 6:37 ` Metzger, Markus T
2012-08-24 13:47 ` Tom Tromey
2012-09-10 6:48 ` Metzger, Markus T
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A78C989F6D9628469189715575E55B2307ACFAD7@IRSMSX102.ger.corp.intel.com \
--to=markus.t.metzger@intel.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
--cc=kettenis@gnu.org \
--cc=markus.t.metzger@gmail.com \
--cc=palves@redhat.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox