From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9695 invoked by alias); 15 Aug 2012 07:59:31 -0000 Received: (qmail 9683 invoked by uid 22791); 15 Aug 2012 07:59:30 -0000 X-SWARE-Spam-Status: No, hits=-7.4 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mga03.intel.com (HELO mga03.intel.com) (143.182.124.21) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 15 Aug 2012 07:59:17 +0000 Received: from azsmga002.ch.intel.com ([10.2.17.35]) by azsmga101.ch.intel.com with ESMTP; 15 Aug 2012 00:59:16 -0700 X-ExtLoop1: 1 Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153]) by AZSMGA002.ch.intel.com with ESMTP; 15 Aug 2012 00:59:15 -0700 Received: from irsmsx151.ger.corp.intel.com (163.33.192.59) by IRSMSX101.ger.corp.intel.com (163.33.3.153) with Microsoft SMTP Server (TLS) id 14.1.355.2; Wed, 15 Aug 2012 08:58:11 +0100 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.176]) by IRSMSX151.ger.corp.intel.com ([169.254.4.31]) with mapi id 14.01.0355.002; Wed, 15 Aug 2012 08:58:10 +0100 From: "Metzger, Markus T" To: Doug Evans CC: "gdb-patches@sourceware.org" , "markus.t.metzger@gmail.com" , "jan.kratochvil@redhat.com" , "palves@redhat.com" , "tromey@redhat.com" , "kettenis@gnu.org" Subject: RE: [patch v3 01/16] gdbserver, build: add -DGDBSERVER Date: Wed, 15 Aug 2012 07:59:00 -0000 Message-ID: References: <1344949171-9545-1-git-send-email-markus.t.metzger@intel.com> <1344949171-9545-2-git-send-email-markus.t.metzger@intel.com> In-Reply-To: Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-08/txt/msg00430.txt.bz2 > -----Original Message----- > From: Doug Evans [mailto:dje@google.com] > Sent: Wednesday, August 15, 2012 2:41 AM Thanks for your review! [...] > > +# Let all files know we're compiling for gdbserver. > > +INTERNAL_CFLAGS +=3D -DGDBSERVER [...] > "+=3D" is a GNU make-ism, I think we can't use it here. >=20 > Plus you missed one: >=20 > gdb_vecs.o: ../common/gdb_vecs.c $(vec_h) $(gdb_vecs_h) $(host_defs_h) > $(CC) -c $(CPPFLAGS) $(INTERNAL_CFLAGS) $< -DGDBSERVER Fixed both. Gdb/common is growing very fast - that's good. I'll send an up= dated patch. Regards, Markus. Intel GmbH Dornacher Strasse 1 85622 Feldkirchen/Muenchen, Deutschland Sitz der Gesellschaft: Feldkirchen bei Muenchen Geschaeftsfuehrer: Douglas Lusk, Peter Gleissner, Hannes Schwaderer, Christ= ian Lamprechter Registergericht: Muenchen HRB 47456 Ust.-IdNr./VAT Registration No.: DE129385895 Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052