Re: [PATCH v2 0/3] Fix stop-on-solib event failures

[Alan Hayward <Alan.Hayward@arm.com>]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 1299 bytes --]



> On 30 Aug 2019, at 16:51, Gary Benson <gbenson@redhat.com> wrote:
> 
> Hi Alan,
> 
> Alan Hayward wrote:
>> On some Arm targets (namely the buildbot Arm Docker setup) placing
>> breakpoints on just the solib dynamic probes will cause the target
>> process to not stop.  This is due to the probes being invalid - see
>> link in 3/3 for more details.
>> 
>> Fix is to fully validate the probes before using the,.
>> 
>> Patches 1 and 2 are code refactors. The actual fix is in patch 3.
> 
> The code looks good to me, my only caveat being that I think we're
> supposed to wrap lines at 72 columns (unless that changed) and some
> lines in your patches seem too long.  I noticed it in comments, but
> possibly it's in code too.  With that fixed (or, not fixed if we
> don't wrap at 72 columns any more) I'd say this is good to commit.
> Thank you for doing the work!
> 

I’ve always kept within 80. Double checking the coding standards, it has:
https://sourceware.org/gdb/wiki/Internals%20GDB-C-Coding-Standards#Column_limits
I’ve always wondered why there’s a lot of code that wraps earlier and
that explains why. (personally I’d prefer even longer, but that’s just me).

Anyway, pushed patch to head.
Thanks!

Alan.


\x16º&Öéj×!zÊÞ¶êçן9ãib²Ö«r\x18\x1dn–­r\x17¬