From: Alan Hayward <Alan.Hayward@arm.com>
To: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Cc: nd <nd@arm.com>, Alan Hayward <Alan.Hayward@arm.com>
Subject: [PATCH v2 0/3] Fix stop-on-solib event failures
Date: Wed, 21 Aug 2019 15:58:00 -0000 [thread overview]
Message-ID: <20190821155816.45504-1-alan.hayward@arm.com> (raw)
On some Arm targets (namely the buildbot Arm Docker setup) placing breakpoints
on just the solib dynamic probes will cause the target process to not stop.
This is due to the probes being invalid - see link in 3/3 for more details.
Fix is to fully validate the probes before using the,.
Patches 1 and 2 are code refactors. The actual fix is in patch 3.
Alan Hayward (3):
Refactor svr4_create_solib_event_breakpoints
Use gdbarch for probe::get_argument_count
Check arguments for all probes before using them
gdb/break-catch-throw.c | 2 +-
gdb/dtrace-probe.c | 4 +-
gdb/probe.c | 7 +-
gdb/probe.h | 2 +-
gdb/solib-svr4.c | 139 ++++++++++++++++++++--------------------
gdb/stap-probe.c | 6 +-
6 files changed, 80 insertions(+), 80 deletions(-)
--
2.20.1 (Apple Git-117)
next reply other threads:[~2019-08-21 15:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-21 15:58 Alan Hayward [this message]
2019-08-21 15:58 ` [PATCH v2 2/3] Use gdbarch for probe::get_argument_count Alan Hayward
2019-09-04 17:58 ` Sergio Durigan Junior
2019-09-04 18:00 ` Sergio Durigan Junior
2019-08-21 15:58 ` [PATCH v2 3/3] Check arguments for all probes before using them Alan Hayward
2019-08-21 15:58 ` [PATCH v2 1/3] Refactor svr4_create_solib_event_breakpoints Alan Hayward
2019-08-30 15:51 ` [PATCH v2 0/3] Fix stop-on-solib event failures Gary Benson
2019-09-02 13:20 ` Alan Hayward
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190821155816.45504-1-alan.hayward@arm.com \
--to=alan.hayward@arm.com \
--cc=gdb-patches@sourceware.org \
--cc=nd@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox