From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 115504 invoked by alias); 21 Aug 2019 15:58:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 115439 invoked by uid 89); 21 Aug 2019 15:58:39 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-13.6 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: EUR04-HE1-obe.outbound.protection.outlook.com Received: from mail-eopbgr70053.outbound.protection.outlook.com (HELO EUR04-HE1-obe.outbound.protection.outlook.com) (40.107.7.53) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 21 Aug 2019 15:58:38 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=c7gINmcx/e7BD10+Shd50oy+u2XqmXp0SEMcm3JGAfk=; b=WRbDxKCeQVzAuHL+PkRG5HUI9USZYMsN917hvn+Cxuv0bMKtB6YnXx6jNk3eRHNm7jv5wATVEfZqsZq/3do5EGf+rKdzk36xcyXFEyWRcMXCxaQQCAzZ6L9ez479gKNM6VHrRcQvFPofyKf48OvlKc+rqLqeB2v/dqjjVof6fnw= Received: from VI1PR08CA0174.eurprd08.prod.outlook.com (2603:10a6:800:d1::28) by VI1PR0802MB2607.eurprd08.prod.outlook.com (2603:10a6:800:b9::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2178.18; Wed, 21 Aug 2019 15:58:32 +0000 Received: from VE1EUR03FT018.eop-EUR03.prod.protection.outlook.com (2a01:111:f400:7e09::207) by VI1PR08CA0174.outlook.office365.com (2603:10a6:800:d1::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.2178.16 via Frontend Transport; Wed, 21 Aug 2019 15:58:32 +0000 Authentication-Results: spf=temperror (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; sourceware.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;sourceware.org; dmarc=temperror action=none header.from=arm.com; Received-SPF: TempError (protection.outlook.com: error in processing during lookup of arm.com: DNS Timeout) Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT018.mail.protection.outlook.com (10.152.18.135) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.2178.16 via Frontend Transport; Wed, 21 Aug 2019 15:58:31 +0000 Received: ("Tessian outbound 578a71fe5eaa:v26"); Wed, 21 Aug 2019 15:58:27 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 1104c6f19267a2b5 X-CR-MTA-TID: 64aa7808 Received: from 0e7a583c9ae6.2 (cr-mta-lb-1.cr-mta-net [104.47.4.53]) by 64aa7808-outbound-1.mta.getcheckrecipient.com id 05E4780E-AFF4-4AAC-BF3D-B548A8420DB6.1; Wed, 21 Aug 2019 15:58:22 +0000 Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-am5eur02lp2053.outbound.protection.outlook.com [104.47.4.53]) by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 0e7a583c9ae6.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384); Wed, 21 Aug 2019 15:58:22 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=i/pcNFgoZGt1+0+xs/Ab6v7EEV7kYC5QgjzD4M/AnaNbVMhKfOWNyJYZuYgMLTX5RuGQE/gyxJNLyHJ+lFWs9Yk8C/eeKTqYWexwcnPs6I8RaszID80xqEX44luxAE1Za166xnMs4W6PFMthdz8ad1nL3QALyBPO6dKbnB9rkrekmo83bxbyviCMJ3zbFq6m7FDJJ+V3Bjh1KeExwSmBxX9tyNq2+dVXkPephqsWNllHRvKdb7bPnOVQces4n5PsJDC3IDegJv2j8MO7nBLTaL+h0LH3hq4BqD9tyrjpeE4KCmIrzeFd/EfS0SGib6YwP8a80Zj6/dyMfDUwHGFgqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=c7gINmcx/e7BD10+Shd50oy+u2XqmXp0SEMcm3JGAfk=; b=ICvI0Yoaa4ao8NpI87zX8UNe3JyN6d/Scw+J45PrTx1oI345ETDDA6Fjy5uM7Gqw3TjR520Az5/J5+myzi6OcnSfsUwS/ypAEdNSrdgkoBhrvUh6m53jglKzaV8OJRJwdUQd9+GSCqfXAMxy0vUky2SJjDD3y9OnZZDVLb1cK0P3e3jkuka3430zZEPcq9rROp/W8CeIvq0KHrLy7skl7JXmBy0yjH/L/LIpZbfGjWDGlCKnUfMYV6ULDy59r9FlJA4Gl2MRVPQd2mIUK69FZAK/wBDDxwPV/AI8RXQdrmxKAikldK978U0chbVI/b86iKd+/Pn5HBxJEghkFDSIcg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=c7gINmcx/e7BD10+Shd50oy+u2XqmXp0SEMcm3JGAfk=; b=WRbDxKCeQVzAuHL+PkRG5HUI9USZYMsN917hvn+Cxuv0bMKtB6YnXx6jNk3eRHNm7jv5wATVEfZqsZq/3do5EGf+rKdzk36xcyXFEyWRcMXCxaQQCAzZ6L9ez479gKNM6VHrRcQvFPofyKf48OvlKc+rqLqeB2v/dqjjVof6fnw= Received: from DB6PR0802MB2133.eurprd08.prod.outlook.com (10.172.227.22) by DB6PR0802MB2344.eurprd08.prod.outlook.com (10.172.228.135) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2178.19; Wed, 21 Aug 2019 15:58:20 +0000 Received: from DB6PR0802MB2133.eurprd08.prod.outlook.com ([fe80::8c83:15d:248f:3a]) by DB6PR0802MB2133.eurprd08.prod.outlook.com ([fe80::8c83:15d:248f:3a%10]) with mapi id 15.20.2178.020; Wed, 21 Aug 2019 15:58:20 +0000 From: Alan Hayward To: "gdb-patches@sourceware.org" CC: nd , Alan Hayward Subject: [PATCH v2 0/3] Fix stop-on-solib event failures Date: Wed, 21 Aug 2019 15:58:00 -0000 Message-ID: <20190821155816.45504-1-alan.hayward@arm.com> Authentication-Results-Original: spf=none (sender IP is ) smtp.mailfrom=Alan.Hayward@arm.com; X-Microsoft-Antispam-Untrusted: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020);SRVR:DB6PR0802MB2344; x-ms-exchange-transport-forked: True x-checkrecipientrouted: true x-ms-oob-tlc-oobclassifiers: OLM:6790;OLM:6790; X-Forefront-Antispam-Report-Untrusted: SFV:NSPM;SFS:(10009020)(4636009)(366004)(376002)(346002)(396003)(136003)(39860400002)(189003)(199004)(476003)(486006)(2616005)(25786009)(4744005)(478600001)(2501003)(86362001)(66066001)(1076003)(6486002)(14454004)(53936002)(5640700003)(81166006)(81156014)(8936002)(44832011)(8676002)(4326008)(5660300002)(50226002)(102836004)(36756003)(66946007)(6512007)(6916009)(6436002)(386003)(6506007)(3846002)(2351001)(71190400001)(71200400001)(6116002)(52116002)(305945005)(186003)(14444005)(256004)(316002)(7736002)(26005)(66476007)(99286004)(2906002)(66446008)(64756008)(66556008)(54906003);DIR:OUT;SFP:1101;SCL:1;SRVR:DB6PR0802MB2344;H:DB6PR0802MB2133.eurprd08.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Message-Info-Original: XQgv+ru60c66ivXkaW/9OFpAoFvE+DZV2VD+HdyntahVgDbPDUvvl/Zlt665UzN038u9oFhCLfuwVJqDz2lSOYze+GWKviqLd9kOvAsJ2dAeUnj64Hj+VcXhRnSOh9MZnDnkkbdSD3gE3kyDAvzSsJxH5VQRAXjtGEuiEAihjNzdR3LRXK2DLJLN02naBVWz7TWZLJRoOzAnAybx3dghAYt+Z3UXZYC67/Y6TOOZHGDDJWjgkIzO6vNAbC5SBM9qiV1UAmRrrnd3FcUiAa3mPGB3BNKrIWSb/zG6aimS0KzhTWnlfCVJGib9Ypxwv3hNZDZlxUkS8/+KFu45GtzKEcVo99K6qe3TtwH2y4e/yyZA+8UA+uUu2Wc48Ry+qRo0z/tGYmuATMS3FxKtNeEK5+/FvVVUPOlgKjHKkWebrds= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Original-Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Alan.Hayward@arm.com; Return-Path: Alan.Hayward@arm.com X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT018.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: cf997d6c-568a-48b4-df0f-08d726506394 X-IsSubscribed: yes X-SW-Source: 2019-08/txt/msg00487.txt.bz2 On some Arm targets (namely the buildbot Arm Docker setup) placing breakpoi= nts on just the solib dynamic probes will cause the target process to not stop. This is due to the probes being invalid - see link in 3/3 for more details. Fix is to fully validate the probes before using the,. Patches 1 and 2 are code refactors. The actual fix is in patch 3. Alan Hayward (3): Refactor svr4_create_solib_event_breakpoints Use gdbarch for probe::get_argument_count Check arguments for all probes before using them gdb/break-catch-throw.c | 2 +- gdb/dtrace-probe.c | 4 +- gdb/probe.c | 7 +- gdb/probe.h | 2 +- gdb/solib-svr4.c | 139 ++++++++++++++++++++-------------------- gdb/stap-probe.c | 6 +- 6 files changed, 80 insertions(+), 80 deletions(-) --=20 2.20.1 (Apple Git-117)