From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26418 invoked by alias); 2 Sep 2019 13:20:38 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 26211 invoked by uid 89); 2 Sep 2019 13:20:38 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-11.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy=placing X-HELO: EUR03-DB5-obe.outbound.protection.outlook.com Received: from mail-eopbgr40089.outbound.protection.outlook.com (HELO EUR03-DB5-obe.outbound.protection.outlook.com) (40.107.4.89) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 02 Sep 2019 13:20:36 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=H6vZgB42dhqUobo7HPqgpymAMpz9cZfkxWlFR17XHHw=; b=NKksrPpB4seqeUmdsojlRO3SvW+O6qbZPRMzGnyDgfY+WsYn378pnchCk72wgI3YuPAPNDc9Rwahv0UeQu5k74J7ybBJI0ufkk/CG95tVJGrdTDYRj8m1vPAOoiRNtRrafOET+HAilgHge8B9qpDiS1uAz16xzkj5ehDNW60iXo= Received: from VI1PR08CA0193.eurprd08.prod.outlook.com (2603:10a6:800:d2::23) by AM5PR0801MB1841.eurprd08.prod.outlook.com (2603:10a6:203:2e::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2220.22; Mon, 2 Sep 2019 13:20:31 +0000 Received: from AM5EUR03FT059.eop-EUR03.prod.protection.outlook.com (2a01:111:f400:7e08::205) by VI1PR08CA0193.outlook.office365.com (2603:10a6:800:d2::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.2220.18 via Frontend Transport; Mon, 2 Sep 2019 13:20:31 +0000 Authentication-Results: spf=temperror (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; sourceware.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;sourceware.org; dmarc=temperror action=none header.from=arm.com; Received-SPF: TempError (protection.outlook.com: error in processing during lookup of arm.com: DNS Timeout) Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT059.mail.protection.outlook.com (10.152.17.193) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.2220.16 via Frontend Transport; Mon, 2 Sep 2019 13:20:29 +0000 Received: ("Tessian outbound f83cc93ed55d:v27"); Mon, 02 Sep 2019 13:20:29 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 5be9f2d6ca877802 X-CR-MTA-TID: 64aa7808 Received: from 949bf75fd57c.1 (ip-172-16-0-2.eu-west-1.compute.internal [104.47.12.58]) by 64aa7808-outbound-1.mta.getcheckrecipient.com id 52AE8899-787A-49F4-BF54-768802204F78.1; Mon, 02 Sep 2019 13:20:24 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04lp2058.outbound.protection.outlook.com [104.47.12.58]) by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 949bf75fd57c.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 02 Sep 2019 13:20:24 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VCtN5Dc9imGNj6tuOZdxWYbHUXjMpgljKY1H/KveiuMqLwM0fUK30/L0zDDNkF846hOGNIADB/1JYA5pJwKGiAwEiyRLZD+PZvY8o8XDHJHUarL1xjQmi39vFB875UhbU5cuGZLfPVnnKBA8HDmKoiNy0U3HtO24Xbo07XuiV1Fvg7bxbLCSAQKKV3Ckwt67C4JtECqrtoICdOJmXRA9kgwZtgL88p9EZnwDYpe1dz4i4hkZ226iS+aTmhNf4TofLzKbkhAfkbkquHJdYOlSV0+ZM01Bk4CN2c63HNJKKynOEZQVr9nJAppb9kr7t+efl+I3Br/YqN0PPkvawMjMhg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=H6vZgB42dhqUobo7HPqgpymAMpz9cZfkxWlFR17XHHw=; b=EBd1Yaa9ddKnr/2CGeDJCosOm0NkL7X67U2oA8AMy/DpTNzgu4JipS/cnrGsHLo3MW8ONjZAHWkBBwS5nJP/ROX7tIX6jAHzp3sFC5VxwNNwYu5QbhQJDCRVdPxu+0LU8U0fZblCSPd7E5a3XfcrU3VYPtkt+9renvCPIEWTMmYEr7djlAmdAI2dXIAPC6qfTyCoGhS95uMq0aC0Vw4ZkernbgYr8RdyumXFxrd9/ryrFbbqTnhoBJId2jEUr+8gPjlQc8srD6SHkZxM1YMhpmikNy/cbTAnUSlQSCzyhz8Z2bTs2QGhZtceNOHtNrkDUMZxhR+A3V++XamZ3mSivQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=H6vZgB42dhqUobo7HPqgpymAMpz9cZfkxWlFR17XHHw=; b=NKksrPpB4seqeUmdsojlRO3SvW+O6qbZPRMzGnyDgfY+WsYn378pnchCk72wgI3YuPAPNDc9Rwahv0UeQu5k74J7ybBJI0ufkk/CG95tVJGrdTDYRj8m1vPAOoiRNtRrafOET+HAilgHge8B9qpDiS1uAz16xzkj5ehDNW60iXo= Received: from AM4PR0802MB2129.eurprd08.prod.outlook.com (10.172.217.20) by AM4PR0802MB2196.eurprd08.prod.outlook.com (10.172.215.140) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2220.20; Mon, 2 Sep 2019 13:20:23 +0000 Received: from AM4PR0802MB2129.eurprd08.prod.outlook.com ([fe80::4c6f:5888:a04e:7dc5]) by AM4PR0802MB2129.eurprd08.prod.outlook.com ([fe80::4c6f:5888:a04e:7dc5%3]) with mapi id 15.20.2220.021; Mon, 2 Sep 2019 13:20:23 +0000 From: Alan Hayward To: Gary Benson CC: "gdb-patches@sourceware.org" , nd Subject: Re: [PATCH v2 0/3] Fix stop-on-solib event failures Date: Mon, 02 Sep 2019 13:20:00 -0000 Message-ID: References: <20190821155816.45504-1-alan.hayward@arm.com> <20190830155151.GA11044@blade.nx> In-Reply-To: <20190830155151.GA11044@blade.nx> Authentication-Results-Original: spf=none (sender IP is ) smtp.mailfrom=Alan.Hayward@arm.com; X-Microsoft-Antispam-Untrusted: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600166)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020);SRVR:AM4PR0802MB2196; X-MS-Exchange-PUrlCount: 1 x-checkrecipientrouted: true x-ms-oob-tlc-oobclassifiers: OLM:2803;OLM:2803; X-Forefront-Antispam-Report-Untrusted: SFV:NSPM;SFS:(10009020)(4636009)(366004)(136003)(39860400002)(376002)(346002)(396003)(189003)(52314003)(199004)(966005)(33656002)(7736002)(6506007)(2616005)(57306001)(11346002)(53546011)(71190400001)(305945005)(446003)(6436002)(6512007)(486006)(186003)(3846002)(8936002)(4326008)(71200400001)(256004)(14444005)(229853002)(54906003)(5660300002)(6246003)(316002)(66066001)(66946007)(6486002)(102836004)(81166006)(81156014)(50226002)(86362001)(6116002)(36756003)(99286004)(478600001)(66446008)(64756008)(66556008)(66476007)(14454004)(91956017)(76116006)(26005)(8676002)(6916009)(76176011)(2906002)(25786009)(476003)(6306002)(53936002);DIR:OUT;SFP:1101;SCL:1;SRVR:AM4PR0802MB2196;H:AM4PR0802MB2129.eurprd08.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Message-Info-Original: Ud/KniLj3H/X6UWZURTulMQEJMvUdFUhTtcPKItyi81GZ0a8I9kYmM9orQOAjXvcbL/scaKwWz74R883JJusC7whHy74hYEvniqgQ4eDpsidGlmOfI/G9dBrQdRPmno2mwdAqWN+TI1YHxq6RhkyzwbewHdklhAuUrjErKGGsOfBxcB60SGdvbJRt78rzl1fGFm8I/QLg0dw6YriZ83dplfBoj0Y2qaofXf+/dnD3u9mjmX34mP5PPa/vSn6HEpJaZqwwJsmR/Y92OuY9Igfu6c8ZE+F5na8v/vXvP55zG9HCi48PDNM7/n5DA3MwbqI9wWUUogsYlXUB3BMvc0iUGW7WrWnm1+fo9uP03GD6SgSxinG1Bzw8mI6x+tGgNdABDpR+saRemKqVvTVxYdD/91/spH4woRsvEXjD+IueRE= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="utf-8" Content-ID: <1356E6012410A04C99117CB7BB9880D4@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 Original-Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Alan.Hayward@arm.com; Return-Path: Alan.Hayward@arm.com X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT059.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: ad07516a-ce77-43e8-58c3-08d72fa84f96 X-IsSubscribed: yes X-SW-Source: 2019-09/txt/msg00008.txt.bz2 DQoNCj4gT24gMzAgQXVnIDIwMTksIGF0IDE2OjUxLCBHYXJ5IEJlbnNvbiA8 Z2JlbnNvbkByZWRoYXQuY29tPiB3cm90ZToNCj4gDQo+IEhpIEFsYW4sDQo+ IA0KPiBBbGFuIEhheXdhcmQgd3JvdGU6DQo+PiBPbiBzb21lIEFybSB0YXJn ZXRzIChuYW1lbHkgdGhlIGJ1aWxkYm90IEFybSBEb2NrZXIgc2V0dXApIHBs YWNpbmcNCj4+IGJyZWFrcG9pbnRzIG9uIGp1c3QgdGhlIHNvbGliIGR5bmFt aWMgcHJvYmVzIHdpbGwgY2F1c2UgdGhlIHRhcmdldA0KPj4gcHJvY2VzcyB0 byBub3Qgc3RvcC4gIFRoaXMgaXMgZHVlIHRvIHRoZSBwcm9iZXMgYmVpbmcg aW52YWxpZCAtIHNlZQ0KPj4gbGluayBpbiAzLzMgZm9yIG1vcmUgZGV0YWls cy4NCj4+IA0KPj4gRml4IGlzIHRvIGZ1bGx5IHZhbGlkYXRlIHRoZSBwcm9i ZXMgYmVmb3JlIHVzaW5nIHRoZSwuDQo+PiANCj4+IFBhdGNoZXMgMSBhbmQg MiBhcmUgY29kZSByZWZhY3RvcnMuIFRoZSBhY3R1YWwgZml4IGlzIGluIHBh dGNoIDMuDQo+IA0KPiBUaGUgY29kZSBsb29rcyBnb29kIHRvIG1lLCBteSBv bmx5IGNhdmVhdCBiZWluZyB0aGF0IEkgdGhpbmsgd2UncmUNCj4gc3VwcG9z ZWQgdG8gd3JhcCBsaW5lcyBhdCA3MiBjb2x1bW5zICh1bmxlc3MgdGhhdCBj aGFuZ2VkKSBhbmQgc29tZQ0KPiBsaW5lcyBpbiB5b3VyIHBhdGNoZXMgc2Vl bSB0b28gbG9uZy4gIEkgbm90aWNlZCBpdCBpbiBjb21tZW50cywgYnV0DQo+ IHBvc3NpYmx5IGl0J3MgaW4gY29kZSB0b28uICBXaXRoIHRoYXQgZml4ZWQg KG9yLCBub3QgZml4ZWQgaWYgd2UNCj4gZG9uJ3Qgd3JhcCBhdCA3MiBjb2x1 bW5zIGFueSBtb3JlKSBJJ2Qgc2F5IHRoaXMgaXMgZ29vZCB0byBjb21taXQu DQo+IFRoYW5rIHlvdSBmb3IgZG9pbmcgdGhlIHdvcmshDQo+IA0KDQpJ4oCZ dmUgYWx3YXlzIGtlcHQgd2l0aGluIDgwLiBEb3VibGUgY2hlY2tpbmcgdGhl IGNvZGluZyBzdGFuZGFyZHMsIGl0IGhhczoNCmh0dHBzOi8vc291cmNld2Fy ZS5vcmcvZ2RiL3dpa2kvSW50ZXJuYWxzJTIwR0RCLUMtQ29kaW5nLVN0YW5k YXJkcyNDb2x1bW5fbGltaXRzDQpJ4oCZdmUgYWx3YXlzIHdvbmRlcmVkIHdo eSB0aGVyZeKAmXMgYSBsb3Qgb2YgY29kZSB0aGF0IHdyYXBzIGVhcmxpZXIg YW5kDQp0aGF0IGV4cGxhaW5zIHdoeS4gKHBlcnNvbmFsbHkgSeKAmWQgcHJl ZmVyIGV2ZW4gbG9uZ2VyLCBidXQgdGhhdOKAmXMganVzdCBtZSkuDQoNCkFu eXdheSwgcHVzaGVkIHBhdGNoIHRvIGhlYWQuDQpUaGFua3MhDQoNCkFsYW4u DQoNCg0K >From gdb-patches-return-158542-listarch-gdb-patches=sources.redhat.com@sourceware.org Mon Sep 02 13:26:12 2019 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 64923 invoked by alias); 2 Sep 2019 13:26:12 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 64914 invoked by uid 89); 2 Sep 2019 13:26:12 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-13.3 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: mx1.suse.de Received: from mx2.suse.de (HELO mx1.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 02 Sep 2019 13:26:11 +0000 Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 196E6AE9A; Mon, 2 Sep 2019 13:26:09 +0000 (UTC) Subject: Re: [PATCH 3/3] gdb/testsuite: Make use of exec_has_index_section function To: Andrew Burgess Cc: gdb-patches@sourceware.org References: <8e6a86ffac28f50f57a826daf8cb4647e4de2ad3.1567353237.git.andrew.burgess@embecosm.com> <20190902131408.GB6076@embecosm.com> From: Tom de Vries Openpgp: preference=signencrypt Message-ID: <0384183c-87ca-3856-56a6-db124000c14b@suse.de> Date: Mon, 02 Sep 2019 13:26:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190902131408.GB6076@embecosm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2019-09/txt/msg00009.txt.bz2 Content-length: 1065 On 02-09-19 15:14, Andrew Burgess wrote: > * Tom de Vries [2019-09-02 13:21:36 +0200]: > >> On 01-09-19 18:08, Andrew Burgess wrote: >>> Make use of exec_has_index_section library function rather than >>> manually checking in the 'maintenance info sections' output. Should >>> make no difference to the test results, just makes the code easier to >>> read. >>> >> >> I agree that it's nicer to test this using a proc call. I just wonder >> whether we should move the removed code to the exec_has_index_section >> proc to handle the case that there's no readelf. Then again, that might >> be overkill, I'm not sure. > > Possibly, but other functions in lib/gdb.exp don't provide non-readelf > alternatives. Also, as readelf is in the same tree as GDB it feels > like it should be easy enough for any GDB developer to get access to > readelf. > > I'm inclined to leave things as I have them, but if you (or anyone > else) feels strongly I'm happy to update the patch, just let me know. You've convinced me that it's overkill, thanks. - Tom