From: Simon Marchi <simark@simark.ca>
To: Guinevere Larsen <guinevere@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] gdbsupport: Remove some use after move instances
Date: Tue, 23 Jun 2026 16:30:03 -0400 [thread overview]
Message-ID: <9f13ec54-880e-436b-845d-05b914178e37@simark.ca> (raw)
In-Reply-To: <20260623202153.2743258-2-guinevere@redhat.com>
On 2026-06-23 16:21, Guinevere Larsen wrote:
> A static analysis tool was ran on GDB and pointed out some instances of
> "use after move" in GDB. The instances that could be easily removed
> are related to move constructors for exceptions, that were using the
> parameter's reason in an assert, when they could instead just use their
> own internal "reason" member.
I think it's useful to name the tool and if possible paste one example of
such warning. That can help if someone needs to dig into that change
later (or even when reviewing).
But otherwise this LGTM.
Approved-By: Simon Marchi <simon.marchi@efficios.com>
Simon
next prev parent reply other threads:[~2026-06-23 20:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-23 20:21 Guinevere Larsen
2026-06-23 20:30 ` Simon Marchi [this message]
2026-06-24 11:57 ` Guinevere Larsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9f13ec54-880e-436b-845d-05b914178e37@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=guinevere@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox