Re: [PATCH] gdbsupport: Remove some use after move instances

[Guinevere Larsen <guinevere@redhat.com>]

On 6/23/26 5:30 PM, Simon Marchi wrote:
>
> On 2026-06-23 16:21, Guinevere Larsen wrote:
>> A static analysis tool was ran on GDB and pointed out some instances of
>> "use after move" in GDB. The instances that could be easily removed
>> are related to move constructors for exceptions, that were using the
>> parameter's reason in an assert, when they could instead just use their
>> own internal "reason" member.
> I think it's useful to name the tool and if possible paste one example of
> such warning.  That can help if someone needs to dig into that change
> later (or even when reviewing).

Right, makes sense. For completeness on the mailing list, the tool was 
Coverity (I think), and the failure is the following:

Error: USE_AFTER_MOVE (CWE-457):
gdb-17.1/gdbsupport/common-exceptions.h:281:7: move: "ex" is moved 
(indicated by "std::move(ex)").
gdb-17.1/gdbsupport/common-exceptions.h:283:5: use_after_move: "ex" is 
used after it has been already moved.
#  281|       : gdb_exception (std::move (ex))
#  282|     {
#  283|->     gdb_assert (ex.reason == RETURN_ERROR);
#  284|     }
#  285|   };

> But otherwise this LGTM.
>
> Approved-By: Simon Marchi <simon.marchi@efficios.com>
>
> Simon
>

-- 
Cheers,
Guinevere Larsen
it/its
she/her (deprecated)