From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id SKQYEujsOmogTxUAWB0awg (envelope-from ) for ; Tue, 23 Jun 2026 16:30:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1782246632; bh=bphtxaejqmOaY7T3JpPJ72XQJxMUISGUsGb5y6Mk+b0=; h=Date:Subject:To:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=i8mPsbOdfgxTfyOCda1lCaEXo7A3utUNkdJzteIlCc2kkMjFmKp8+ktk2ryDLc4yj E6kYtW9sKt0iyM8VbE5YXGz8Kb0HUaM+tHPaMGelVVueF/IvN2wlGtss9z5Ic/uQX8 gWrZT2VD5cG61X8ZvCTaBjcX/4DanBT5pyxHRfuw= Received: by simark.ca (Postfix, from userid 112) id 2336E1E098; Tue, 23 Jun 2026 16:30:32 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=l93r75wN; dkim-atps=neutral Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 413511E070 for ; Tue, 23 Jun 2026 16:30:31 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 313764BA2E13 for ; Tue, 23 Jun 2026 20:30:30 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 313764BA2E13 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=l93r75wN Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 58F104BA540B for ; Tue, 23 Jun 2026 20:30:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 58F104BA540B Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 58F104BA540B Authentication-Results: sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1782246606; cv=none; b=dfjjzVUCBslv68NJCvVp3K01pFazw7+6/o6fbsnwj/4zS5b9G4QX/pIBPKwiKRbhNjiSgobg4LTqSxD+YRssP6gJvw+xKUFjwQVAKyX626o5665uYVH+M3Y6XyHQHR+JmjIESNRc2obhPPrUrbPL/6+bwyk7BOC4VyLSOVF2x5Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1782246606; c=relaxed/simple; bh=bphtxaejqmOaY7T3JpPJ72XQJxMUISGUsGb5y6Mk+b0=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=C/YhZoQecSFdiLaaZnTujkODRZtwN5zJbsxv14M9E002qbdnW0vUFMjEJjkFChXf6fObZmbrb6DCV7QeOpYallVUaxSRu8e3/a72mOHubipvLN+LmUcf7w+sAGDxmB7n5oEHzAD6LGhemhuwaD/VXIlwCvNiphnxmghgdint8Rk= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=l93r75wN DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 58F104BA540B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1782246604; bh=bphtxaejqmOaY7T3JpPJ72XQJxMUISGUsGb5y6Mk+b0=; h=Date:Subject:To:References:From:In-Reply-To:From; b=l93r75wNlTrUElsgpR0DTjYiz/KlSW2r+zS838ZBCu1IJE920/IPD40XCFpjAXAc+ xEPE08O6ZXW48ETKW6rrI7kUZi9kmU2KMVLE8qIOhxipEdrcU8wLkM8wGpk3TzZII3 Q+hdZHsYOKuhdxVF3b19YCoPZ6kkQTC3n3IGwpOg= Received: by simark.ca (Postfix) id 4CBE61E070; Tue, 23 Jun 2026 16:30:04 -0400 (EDT) Message-ID: <9f13ec54-880e-436b-845d-05b914178e37@simark.ca> Date: Tue, 23 Jun 2026 16:30:03 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gdbsupport: Remove some use after move instances To: Guinevere Larsen , gdb-patches@sourceware.org References: <20260623202153.2743258-2-guinevere@redhat.com> Content-Language: en-US From: Simon Marchi In-Reply-To: <20260623202153.2743258-2-guinevere@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 2026-06-23 16:21, Guinevere Larsen wrote: > A static analysis tool was ran on GDB and pointed out some instances of > "use after move" in GDB. The instances that could be easily removed > are related to move constructors for exceptions, that were using the > parameter's reason in an assert, when they could instead just use their > own internal "reason" member. I think it's useful to name the tool and if possible paste one example of such warning. That can help if someone needs to dig into that change later (or even when reviewing). But otherwise this LGTM. Approved-By: Simon Marchi Simon