From: Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
To: Zied Guermazi <zied.guermazi@trande.de>, gdb-patches@sourceware.org
Subject: Re: [PATCH 0/1] btrace: get page size using sysconf (_SC_PAGESIZE) instead of PAGE_SIZE
Date: Sun, 24 Apr 2022 20:13:23 -0400 [thread overview]
Message-ID: <9e6939e1-1bae-c398-2547-96832692269f@simark.ca> (raw)
In-Reply-To: <20220424211541.70674-1-zied.guermazi@trande.de>
On 2022-04-24 17:15, Zied Guermazi wrote:
> PAGE_SIZE is not defined in all systems, therefore use the posix call sysconf (_SC_PAGESIZE)
Hi,
This information should be in the commit message of the patch itself,
not in the cover letter. Also, can you please give concrete examples of
systems where this isn't defined, to give some context? It should also
be in the commit message.
Simon
next prev parent reply other threads:[~2022-04-25 0:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-24 21:15 Zied Guermazi
2022-04-24 21:15 ` [PATCH 1/1] " Zied Guermazi
2022-04-25 5:03 ` Metzger, Markus T via Gdb-patches
2022-04-25 7:02 ` Zied Guermazi
2022-04-25 7:36 ` Metzger, Markus T via Gdb-patches
2022-04-25 0:13 ` Simon Marchi via Gdb-patches [this message]
2022-04-25 6:54 ` [PATCH 0/1] btrace: " Zied Guermazi
2022-04-25 18:47 ` John Baldwin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9e6939e1-1bae-c398-2547-96832692269f@simark.ca \
--to=gdb-patches@sourceware.org \
--cc=simark@simark.ca \
--cc=zied.guermazi@trande.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox