From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 7U6jNrnnZWJiXQIAWB0awg (envelope-from ) for ; Sun, 24 Apr 2022 20:13:45 -0400 Received: by simark.ca (Postfix, from userid 112) id BD9B31E086; Sun, 24 Apr 2022 20:13:45 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=V939TJ6i; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_DYNAMIC, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 3F5151E048 for ; Sun, 24 Apr 2022 20:13:45 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id CBC3F385800E for ; Mon, 25 Apr 2022 00:13:44 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CBC3F385800E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1650845624; bh=XFI3Qax5mMjFOrRi+XJySbN8BpUIZ1RMiwVaH160N7U=; h=Date:Subject:To:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=V939TJ6iz7NlGllVq+aR24JIIXWk0d8MNX3O9mkYp4dmkAwDCzKi6Y/vNax5dwKC/ SZQsK+w0KrC29fIEP9fgx6zsWkaA2rbBJus0V1lUmFxxlYHkqCQZUDOhUFZLzSzRuI 350NyZyU/UtJf7y4UvPrHPhbUEYyrMbk1vQJtSks= Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 13BD53858D33 for ; Mon, 25 Apr 2022 00:13:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 13BD53858D33 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 0B8281E00D; Sun, 24 Apr 2022 20:13:23 -0400 (EDT) Message-ID: <9e6939e1-1bae-c398-2547-96832692269f@simark.ca> Date: Sun, 24 Apr 2022 20:13:23 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH 0/1] btrace: get page size using sysconf (_SC_PAGESIZE) instead of PAGE_SIZE Content-Language: en-US To: Zied Guermazi , gdb-patches@sourceware.org References: <20220424211541.70674-1-zied.guermazi@trande.de> In-Reply-To: <20220424211541.70674-1-zied.guermazi@trande.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 2022-04-24 17:15, Zied Guermazi wrote: > PAGE_SIZE is not defined in all systems, therefore use the posix call sysconf (_SC_PAGESIZE) Hi, This information should be in the commit message of the patch itself, not in the cover letter. Also, can you please give concrete examples of systems where this isn't defined, to give some context? It should also be in the commit message. Simon