Re: [PATCH 0/1] btrace: get page size using sysconf (_SC_PAGESIZE) instead of PAGE_SIZE

[Zied Guermazi <zied.guermazi@trande.de>]

Hi Simon,

thanks for your feedback, I will put the info in the commit message itself.

the issue was observed when cross compiling for aarch64 GNU/Linux 
machine while activating the code. It was also discussed here: 
https://github.com/intel/libipt/issues/11 .

Kind Regards

Zied Guermazi


On 25.04.22 02:13, Simon Marchi wrote:
> On 2022-04-24 17:15, Zied Guermazi wrote:
>> PAGE_SIZE is not defined in all systems, therefore use the posix call sysconf (_SC_PAGESIZE)
> Hi,
>
> This information should be in the commit message of the patch itself,
> not in the cover letter.  Also, can you please give concrete examples of
> systems where this isn't defined, to give some context?  It should also
> be in the commit message.
>
> Simon
-- 

*Zied Guermazi*
founder

Trande GmbH
Leuschnerstraße 2
69469 Weinheim/Germany

Mobile: +491722645127
mailto:zied.guermazi@trande.de <mailto:zied.guermazi@trande.de>

*Trande GmbH*
Leuschnerstraße 2, D-69469 Weinheim; Telefon: +491722645127
Sitz der Gesellschaft: Weinheim- Registergericht: AG Mannheim HRB 736209 
- Geschäftsführung: Zied Guermazi

*Confidentiality Note*
This message is intended only for the use of the named recipient(s) and 
may contain confidential and/or privileged information. If you are not 
the intended recipient, please contact the sender and delete the 
message. Any unauthorized use of the information contained in this 
message is prohibited.