From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id gIiICtJFZmKiaAIAWB0awg (envelope-from ) for ; Mon, 25 Apr 2022 02:55:14 -0400 Received: by simark.ca (Postfix, from userid 112) id 24E3D1E058; Mon, 25 Apr 2022 02:55:14 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00,MAILING_LIST_MULTI, NICE_REPLY_A autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id AA0BA1E00D for ; Mon, 25 Apr 2022 02:55:13 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 2A7B63858C51 for ; Mon, 25 Apr 2022 06:55:13 +0000 (GMT) Received: from nx208.node01.secure-mailgate.com (nx208.node01.secure-mailgate.com [89.22.108.208]) by sourceware.org (Postfix) with ESMTPS id E84683858C83 for ; Mon, 25 Apr 2022 06:55:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E84683858C83 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=trande.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=trande.de Received: from host202.checkdomain.de ([185.137.168.148]) by node01.secure-mailgate.com with esmtps (TLSv1.2:AES128-GCM-SHA256:128) (Exim 4.92) (envelope-from ) id 1niscb-00Axyo-NC; Mon, 25 Apr 2022 08:54:59 +0200 X-SecureMailgate-Identity: zied.guermazi@trande.de;host202.checkdomain.de Received: from [192.168.178.48] (dynamic-077-179-168-191.77.179.pool.telefonica.de [77.179.168.191]) (Authenticated sender: zied.guermazi@trande.de) by host202.checkdomain.de (Postfix) with ESMTPSA id 8577428065C; Mon, 25 Apr 2022 08:54:56 +0200 (CEST) X-SecureMailgate-Identity: zied.guermazi@trande.de;host202.checkdomain.de Message-ID: <732442d2-d695-3240-a00c-f84f905326a9@trande.de> Date: Mon, 25 Apr 2022 08:54:56 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH 0/1] btrace: get page size using sysconf (_SC_PAGESIZE) instead of PAGE_SIZE Content-Language: en-US To: Simon Marchi , gdb-patches@sourceware.org References: <20220424211541.70674-1-zied.guermazi@trande.de> <9e6939e1-1bae-c398-2547-96832692269f@simark.ca> From: Zied Guermazi In-Reply-To: <9e6939e1-1bae-c398-2547-96832692269f@simark.ca> X-PPP-Message-ID: <20220425065456.78394.70891@host202.checkdomain.de> X-PPP-Vhost: trande.de X-Originating-IP: 185.137.168.148 X-SecureMailgate-Domain: host202.checkdomain.de X-SecureMailgate-Username: 185.137.168.148 Authentication-Results: secure-mailgate.com; auth=pass smtp.auth=185.137.168.148@host202.checkdomain.de X-SecureMailgate-Outgoing-Class: ham X-SecureMailgate-Outgoing-Evidence: Combined (0.12) X-Recommended-Action: accept X-Filter-ID: Pt3MvcO5N4iKaDQ5O6lkdGlMVN6RH8bjRMzItlySaT+wzoEhkqT5Y6ndlF0zhxW2PUtbdvnXkggZ 3YnVId/Y5jcf0yeVQAvfjHznO7+bT5y68Biu36ESie+sR+xkLlBQfd/bY3WQ8K/RdlotBhEPFAK0 85OYn8S9ZJwCZa4BpjSBGHgCMNibvZ03gNgrP3MUVr1PqUD+Z8q36zsjNGcDYkFRTxbfuBKjJ6eA kw4VYNJdlVTWZJVpGbizxHxt7o8KU1v6P8H8HmLEncfJZqROAw/T+yplt3pxBlMyNm1L8jr6jp0p Q7iN8YfPMN1D3ySeHu1TNmpU1DbKADVuDjTXMfsm5wMH8LavDp/h7RDW3HpVrkGZtteumm+vRWjh HJYA4BAah0N3qPEwUyYM+XoU0pzH5F7TfnOJADweoNsBqVhKQh5Kt7dkFnOcu0dr4Eyki8KkhA1D c75L6tsN4z/N9+4kDqBeCn8nwBijhCUNJGz+m9Y5u4VAiJWVkioLNjHZX9n+Fppg2sTbsOYuMwGG rKoBJ3GsIDHQr7JI7sXkTuRPX6O2KDgB0sXXptn4To9DIjmWspaNNq3zk8Wc70B1UEDHGLIWRRxh sHQ45wxaPsAIa/9gbANbtDrZMN7BmTC47dtSrFArkgELMEFx6DJvYxWT+LsuyPeDXhuGJAvXcqad 6+6AB9mEpRX5vy67WwDjehIqUczFWeS6sE8e1b5/UkBg4yvMn5MBAdwJubari/hLHimqitsRE/ma JSYyinPmBUEBh1BKCVeqNqXTAi+UgO33aBqAN4PmW2WNzfNwqb4HmFDqewO9xyOqCYO8P1aHjjpP i5LVLqjUgQBu50RCinxwne+izm2t5IaXU4WCTLtCJ/k2Jo+Zn4s9cWJWa0GqEzsH0oXL/HFZKwm4 vd61PhVmNQWB1WtvnekgFu+8iV3NOcTZA4sWZMrt2MUfA6oq0Pe0MSXbk0X2IqAQPKIEqHd2xQ+X u65ZkQJPEOgYvEqChCY2L0x1YX105Nk0DLmz0lEireTKR8BnhQOIX4YTBXfbrMFcJFGQ81k55mGX zcgTrk9wwq6nH7z/b3gCyLA3CE5PMKEYWEBhSgz9GzkgfuZRKJHCiRzTr2Y9zfEcSKEvAu21kK65 6rT9uyJ/sjgTutnV80VZWZriW9iCg+A0sc24jyU4G2tsKigFqS5+25pryXziPjJieHJ24C1X66En rzMnbkkeR/bLV8ffzH+ilQ== X-Report-Abuse-To: spam@node04.secure-mailgate.com Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" Hi Simon, thanks for your feedback, I will put the info in the commit message itself. the issue was observed when cross compiling for aarch64 GNU/Linux machine while activating the code. It was also discussed here: https://github.com/intel/libipt/issues/11 . Kind Regards Zied Guermazi On 25.04.22 02:13, Simon Marchi wrote: > On 2022-04-24 17:15, Zied Guermazi wrote: >> PAGE_SIZE is not defined in all systems, therefore use the posix call sysconf (_SC_PAGESIZE) > Hi, > > This information should be in the commit message of the patch itself, > not in the cover letter. Also, can you please give concrete examples of > systems where this isn't defined, to give some context? It should also > be in the commit message. > > Simon -- *Zied Guermazi* founder Trande GmbH Leuschnerstraße 2 69469 Weinheim/Germany Mobile: +491722645127 mailto:zied.guermazi@trande.de *Trande GmbH* Leuschnerstraße 2, D-69469 Weinheim; Telefon: +491722645127 Sitz der Gesellschaft: Weinheim- Registergericht: AG Mannheim HRB 736209 - Geschäftsführung: Zied Guermazi *Confidentiality Note* This message is intended only for the use of the named recipient(s) and may contain confidential and/or privileged information. If you are not the intended recipient, please contact the sender and delete the message. Any unauthorized use of the information contained in this message is prohibited.