Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom de Vries <tdevries@suse.de>
To: Kevin Buettner <kevinb@redhat.com>
Cc: gdb-patches@sourceware.org, Eli Zaretskii <eliz@gnu.org>
Subject: Re: [PATCH 0/3] [gdb] Remove doxygen support
Date: Mon, 1 Jun 2026 13:33:41 +0200	[thread overview]
Message-ID: <9dac016a-4739-4c71-9c70-4c60cc7f0594@suse.de> (raw)
In-Reply-To: <20260529163907.4c2b177b@f42-zbm-amd>

On 5/30/26 1:39 AM, Kevin Buettner wrote:
> Hi Tom,
> 
> Thanks for doing this cleanup.
> 

Hi Kevin,

Thanks for the reviews.

> Claude tells me that '/**<' is also a doxygen marker.  There are 6
> occurrences in gdb/gdbtypes.h and 17 lines with that marker in
> gdb/type-codes.def.
> 
> I think it'd be a good idea to clean up those markers too.
> 

Ack, in a v2 I've added a patch for that ( 
https://sourceware.org/pipermail/gdb-patches/2026-June/227724.html ).

> In part 2, I noted a nit.  Parts 1 and 3 LGTM.  That said, I only gave
> a "Reviewed-by" semi-approval on those since Eli is the documentation
> maintainer for GDB.  After reconsidering, I think I should have given
> an "Approved-by" for part 3 - it's a .h file.  So, for part 2 (after
> the nit is fixed) and part 3:
> 
> Approved-By: Kevin Buettner <kevinb@redhat.com>

I'm guessing that the documentation maintainer role focuses on 
user-visible documentation, so I'm fine with committing without a review 
by Eli.

Thanks,
- Tom

      reply	other threads:[~2026-06-01 11:34 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-29 15:20 Tom de Vries
2026-05-29 15:20 ` [PATCH 1/3] [gdb/doc] " Tom de Vries
2026-05-29 22:56   ` Kevin Buettner
2026-05-29 15:20 ` [PATCH 2/3] [gdb] Remove '/* *' multi-line comment marker Tom de Vries
2026-05-29 23:00   ` Kevin Buettner
2026-05-29 15:20 ` [PATCH 3/3] [gdb] Remove \page marker Tom de Vries
2026-05-29 23:03   ` Kevin Buettner
2026-05-29 23:39 ` [PATCH 0/3] [gdb] Remove doxygen support Kevin Buettner
2026-06-01 11:33   ` Tom de Vries [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9dac016a-4739-4c71-9c70-4c60cc7f0594@suse.de \
    --to=tdevries@suse.de \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=kevinb@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox