From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id VrvGIzZuHWqggC0AWB0awg (envelope-from ) for ; Mon, 01 Jun 2026 07:34:14 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=OUzI8JEr; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=ld4kGpAe; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=xAZQ8k1E; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=e9ukaL6H; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 7C0161E062; Mon, 01 Jun 2026 07:34:14 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id ACE6D1E062 for ; Mon, 01 Jun 2026 07:34:13 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 4CC454BA2E1C for ; Mon, 1 Jun 2026 11:34:12 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4CC454BA2E1C Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=OUzI8JEr; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=ld4kGpAe; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=xAZQ8k1E; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=e9ukaL6H Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by sourceware.org (Postfix) with ESMTPS id 6B99B4BA2E11 for ; Mon, 1 Jun 2026 11:33:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6B99B4BA2E11 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6B99B4BA2E11 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1780313624; cv=none; b=E89kG75Y4qEJ7utSzzvXItBMwk4JHoCoxSh5j6S8Pav0Zcx+fw9E1orDP2hQDxuV9EuHxARNnvETLYpYED9J5wDYc//vDj4L/+6Yl0+v5MlRnweLguEcGRYUPj+1kIkU5KE9esAc8Cd+oPm+TKJeZj7m9OM4M+FPFPUK7XyjLjw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1780313624; c=relaxed/simple; bh=2ysj1b1NnWrWW9lT3VkA11N3w+broozziP4jYmuEkZs=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=VIZOYwVlXVFY42BIwRsnKjpg2YB+PyMmFkizfs2Afy0fgnbKFp92wfy8jq0B2OJMFhNPk84jSZZQx3QDjaEAIS8eD/xJf6wTWRGfDf9/19HNpVcR75QeYzTeFDNFzp0GahNegfVAzNRTV7yOM0Sljq6qqzXcA8qsvVdb1utnfno= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=OUzI8JEr; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=ld4kGpAe; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=xAZQ8k1E; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=e9ukaL6H DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6B99B4BA2E11 Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 46A5C66F03; Mon, 1 Jun 2026 11:33:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1780313623; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Kak+W2tGnExh9tPqEvguAg/v3GlVfbA4WDEolnQ0RCs=; b=OUzI8JErLSBdpN+k/i0o3nQei5FrGI8x9ucG2n8MhLAF4Z+xV0zJxorpoUqwRIyYH+degG WSuQmg0+qYemqgg5DAwNPFKLtjyPpXhC6eW1pqfurJWq+4/LPx8MOwUPPdKy736W6kPNcz QcFTni72Mc5vE4B72SFf03mXJUoSnYw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1780313623; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Kak+W2tGnExh9tPqEvguAg/v3GlVfbA4WDEolnQ0RCs=; b=ld4kGpAeqGQnxCUSVz2HcUAgudGYj5+K/nvFd7f5/i7AZL5A7OfzCE2hV067xDq+L2a7Gl fF5Mpaw5/1i1QtBw== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1780313622; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Kak+W2tGnExh9tPqEvguAg/v3GlVfbA4WDEolnQ0RCs=; b=xAZQ8k1Em5Q4aervJnVxOTlztJD2CvsR7VYmcoQ5/l6SoEET4NIgILjh144eG+SVG//+eu S9Wbk0bTy6xsL6UHxMY+ow+jaBDKVHdcvrcKZZBkc5NpNQXRQRVPBFxd3nwLC5xCwUopNq E5lpVIxfMArd5BnNZZoewoXhIikUEUs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1780313622; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Kak+W2tGnExh9tPqEvguAg/v3GlVfbA4WDEolnQ0RCs=; b=e9ukaL6HAQZzvGcAr+3HltheaPTWtH/1cMjt+xfJC5CFZy9Bn7oJI/PQ1NbfvwL8hH6UeA XRDOCGVIAZ39u3BA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 28F74779A7; Mon, 1 Jun 2026 11:33:42 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id yTSRCBZuHWqGTgAAD6G6ig (envelope-from ); Mon, 01 Jun 2026 11:33:42 +0000 Message-ID: <9dac016a-4739-4c71-9c70-4c60cc7f0594@suse.de> Date: Mon, 1 Jun 2026 13:33:41 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/3] [gdb] Remove doxygen support To: Kevin Buettner Cc: gdb-patches@sourceware.org, Eli Zaretskii References: <20260529152035.4016664-1-tdevries@suse.de> <20260529163907.4c2b177b@f42-zbm-amd> Content-Language: en-US From: Tom de Vries In-Reply-To: <20260529163907.4c2b177b@f42-zbm-amd> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spamd-Result: default: False [-4.30 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-0.998]; MIME_GOOD(-0.10)[text/plain]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RCVD_VIA_SMTP_AUTH(0.00)[]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; TO_DN_SOME(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; RCVD_COUNT_TWO(0.00)[2]; URIBL_BLOCKED(0.00)[sourceware.org:url,imap1.dmz-prg2.suse.org:helo,suse.de:mid]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo, sourceware.org:url, suse.de:mid] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 5/30/26 1:39 AM, Kevin Buettner wrote: > Hi Tom, > > Thanks for doing this cleanup. > Hi Kevin, Thanks for the reviews. > Claude tells me that '/**<' is also a doxygen marker. There are 6 > occurrences in gdb/gdbtypes.h and 17 lines with that marker in > gdb/type-codes.def. > > I think it'd be a good idea to clean up those markers too. > Ack, in a v2 I've added a patch for that ( https://sourceware.org/pipermail/gdb-patches/2026-June/227724.html ). > In part 2, I noted a nit. Parts 1 and 3 LGTM. That said, I only gave > a "Reviewed-by" semi-approval on those since Eli is the documentation > maintainer for GDB. After reconsidering, I think I should have given > an "Approved-by" for part 3 - it's a .h file. So, for part 2 (after > the nit is fixed) and part 3: > > Approved-By: Kevin Buettner I'm guessing that the documentation maintainer role focuses on user-visible documentation, so I'm fine with committing without a review by Eli. Thanks, - Tom