Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Kevin Buettner <kevinb@redhat.com>
To: Tom de Vries <tdevries@suse.de>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 0/3] [gdb] Remove doxygen support
Date: Fri, 29 May 2026 16:39:07 -0700	[thread overview]
Message-ID: <20260529163907.4c2b177b@f42-zbm-amd> (raw)
In-Reply-To: <20260529152035.4016664-1-tdevries@suse.de>

Hi Tom,

Thanks for doing this cleanup.

Claude tells me that '/**<' is also a doxygen marker.  There are 6
occurrences in gdb/gdbtypes.h and 17 lines with that marker in
gdb/type-codes.def.

I think it'd be a good idea to clean up those markers too.

In part 2, I noted a nit.  Parts 1 and 3 LGTM.  That said, I only gave
a "Reviewed-by" semi-approval on those since Eli is the documentation
maintainer for GDB.  After reconsidering, I think I should have given
an "Approved-by" for part 3 - it's a .h file.  So, for part 2 (after
the nit is fixed) and part 3:

Approved-By: Kevin Buettner <kevinb@redhat.com>

Kevin


  parent reply	other threads:[~2026-05-29 23:39 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-29 15:20 Tom de Vries
2026-05-29 15:20 ` [PATCH 1/3] [gdb/doc] " Tom de Vries
2026-05-29 22:56   ` Kevin Buettner
2026-05-29 15:20 ` [PATCH 2/3] [gdb] Remove '/* *' multi-line comment marker Tom de Vries
2026-05-29 23:00   ` Kevin Buettner
2026-05-29 15:20 ` [PATCH 3/3] [gdb] Remove \page marker Tom de Vries
2026-05-29 23:03   ` Kevin Buettner
2026-05-29 23:39 ` Kevin Buettner [this message]
2026-06-01 11:33   ` [PATCH 0/3] [gdb] Remove doxygen support Tom de Vries

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260529163907.4c2b177b@f42-zbm-amd \
    --to=kevinb@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tdevries@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox