From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id gnLfGbojGmrTCigAWB0awg (envelope-from ) for ; Fri, 29 May 2026 19:39:38 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=GcFdDsJf; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 5A0791E024; Fri, 29 May 2026 19:39:38 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id D79A71E024 for ; Fri, 29 May 2026 19:39:37 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 41AA24BA7990 for ; Fri, 29 May 2026 23:39:37 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 41AA24BA7990 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=GcFdDsJf Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 45CBC4BA23F3 for ; Fri, 29 May 2026 23:39:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 45CBC4BA23F3 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 45CBC4BA23F3 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1780097953; cv=none; b=XhrZ4QKdNQvHfi7RGafp7Y4xtQLQIAZTYc7cbSq7MZYF/62+rAWsSyhfrczPp5j5FzcwX/09qtpwyFXz10U2+wIFXzybRYrhmuN/snz5iu6O/qATLg5ZBf3QxMTtQND2akv7qz6Xxzp+0r7bNljVtKL5uTf43im9WJvkzc4cpdw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1780097953; c=relaxed/simple; bh=PuM1OOuzjjOvmdORgb/8Hf9UgNJu22BrQODCuj0bM5o=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=nJdywriZl+65Pl0Ti2GyGEuyvHYo2PwrKZGJoSVH7h5Mpxs6HbqaK4915kqzh6XKXiLcKRSq086Fr1MXVs/pnsp5dDAh4AGGBlqI521NtGUrMcgnZYLilTDE65MvFn6U1RtZ2uBfPnOhrtc6w+Fg/LhjlKKjTfGlB0VexMimI2o= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=GcFdDsJf DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 45CBC4BA23F3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1780097952; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WGJNwpiroL6sJVRK8y23C3KRr4cxFEf0l5wROBflqkM=; b=GcFdDsJfHa1m8WUlruWev3WDfLd1DOPB4bBvPENFzHd8JOqjNwHtLX/KWGIaKeVvtsJOAz 1mQx7k3E8QOwPgPgDLuycNkkm2I+lOk9McNIe9ed8nvdOCqDubTH4OocgcHMycVeqLHcUF Gym9YB+RkF6wnGGNmsgAA9FFXoYHhQ4= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-146-0P5I3ZgGNKaAtukJYh09YA-1; Fri, 29 May 2026 19:39:11 -0400 X-MC-Unique: 0P5I3ZgGNKaAtukJYh09YA-1 X-Mimecast-MFC-AGG-ID: 0P5I3ZgGNKaAtukJYh09YA_1780097950 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 5E0F21800451; Fri, 29 May 2026 23:39:10 +0000 (UTC) Received: from f42-zbm-amd (unknown [10.22.64.64]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 98BF91955F22; Fri, 29 May 2026 23:39:09 +0000 (UTC) Date: Fri, 29 May 2026 16:39:07 -0700 From: Kevin Buettner To: Tom de Vries Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 0/3] [gdb] Remove doxygen support Message-ID: <20260529163907.4c2b177b@f42-zbm-amd> In-Reply-To: <20260529152035.4016664-1-tdevries@suse.de> References: <20260529152035.4016664-1-tdevries@suse.de> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 8o21nYw-ietfV-WqRR_R0G8H0tzLvSEk5Lauc7oq5e4_1780097950 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Hi Tom, Thanks for doing this cleanup. Claude tells me that '/**<' is also a doxygen marker. There are 6 occurrences in gdb/gdbtypes.h and 17 lines with that marker in gdb/type-codes.def. I think it'd be a good idea to clean up those markers too. In part 2, I noted a nit. Parts 1 and 3 LGTM. That said, I only gave a "Reviewed-by" semi-approval on those since Eli is the documentation maintainer for GDB. After reconsidering, I think I should have given an "Approved-by" for part 3 - it's a .h file. So, for part 2 (after the nit is fixed) and part 3: Approved-By: Kevin Buettner Kevin