Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Sandra Loosemore <sandra@codesourcery.com>
To: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: [patch, testsuite] Disable dw2-dir-file-name.exp on remote and/or Windows host
Date: Tue, 13 Aug 2019 22:29:00 -0000	[thread overview]
Message-ID: <9bb4446e-8a94-496d-ab8c-6d1197ac0728@codesourcery.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 553 bytes --]

This is yet another testsuite fix to clean up results on remote Windows 
host.

For this testcase, I did consider trying to fix it rather than just 
disabling it for remote host, but it looked like it was going to be an 
awful lot of work and trial-and-error (it has almost no comments to 
explain what it is trying to test, or how it is getting there).  I think 
it is at least an incremental improvement to document that it isn't 
expected to work as-is on remote host.  And disabling it does get rid of 
33 completely bogus FAILs.  :-P

OK?

-Sandra

[-- Attachment #2: dw2-dir-file-name.patch --]
[-- Type: text/x-patch, Size: 1824 bytes --]

commit b1c596ea64186661fc17b9e7b410b95ef4b9cc2e
Author: Sandra Loosemore <sandra@codesourcery.com>
Date:   Tue Aug 13 15:13:13 2019 -0700

    Disable dw2-dir-file-name.exp on remote and/or Windows host.
    
    This test has many hardwired assumptions that pathnames on build and
    host are the same, and that POSIX pathname syntax is used.  This
    results in dozens of failures on a remote Windows host.  Fixing these
    assumptions would involve nontrivial rewrites; meanwhile, let's make
    the test results reflect the reality that this testcase isn't supported
    on remote host.
    
    2019-08-13  Sandra Loosemore  <sandra@codesourcery.com>
    
    	gdb/testsuite/
    	* gdb.dwarf2/dw2-dir-file-name.exp: Skip on remote or
    	Windows host.

diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index 38689c1..65fdc6e 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,5 +1,10 @@
 2019-08-13  Sandra Loosemore  <sandra@codesourcery.com>
 
+	* gdb.dwarf2/dw2-dir-file-name.exp: Skip on remote or
+	Windows host.
+
+2019-08-13  Sandra Loosemore  <sandra@codesourcery.com>
+
 	* gdb.base/batch-preserve-term-settings.exp
 	(test_terminal_settings_preserved_after_sigterm): Skip on Windows.
 
diff --git a/gdb/testsuite/gdb.dwarf2/dw2-dir-file-name.exp b/gdb/testsuite/gdb.dwarf2/dw2-dir-file-name.exp
index 246b4af..2933df9 100644
--- a/gdb/testsuite/gdb.dwarf2/dw2-dir-file-name.exp
+++ b/gdb/testsuite/gdb.dwarf2/dw2-dir-file-name.exp
@@ -19,6 +19,12 @@ if {![dwarf2_support]} {
     return 0  
 }
 
+# This test has hard-wired assumptions that host and build filenames are
+# the same, and assumes POSIX pathname syntax.
+if { [is_remote host] || [ishost *-*-mingw*] } {
+    return 0
+}
+
 # Find length of addresses in bytes.
 if {[is_64_target]} {
     set addr_len 8

             reply	other threads:[~2019-08-13 22:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-13 22:29 Sandra Loosemore [this message]
2019-08-15  3:13 ` Simon Marchi
2019-08-15 14:37   ` Sandra Loosemore
2019-08-15 14:48     ` Simon Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9bb4446e-8a94-496d-ab8c-6d1197ac0728@codesourcery.com \
    --to=sandra@codesourcery.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox