Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Simon Marchi <simark@simark.ca>
To: Sandra Loosemore <sandra@codesourcery.com>,
	"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [patch, testsuite] Disable dw2-dir-file-name.exp on remote and/or Windows host
Date: Thu, 15 Aug 2019 03:13:00 -0000	[thread overview]
Message-ID: <18b00c50-2cc0-b327-a06b-25df81b2f70b@simark.ca> (raw)
In-Reply-To: <9bb4446e-8a94-496d-ab8c-6d1197ac0728@codesourcery.com>

On 2019-08-13 6:29 p.m., Sandra Loosemore wrote:
> This is yet another testsuite fix to clean up results on remote Windows 
> host.
> 
> For this testcase, I did consider trying to fix it rather than just 
> disabling it for remote host, but it looked like it was going to be an 
> awful lot of work and trial-and-error (it has almost no comments to 
> explain what it is trying to test, or how it is getting there).  I think 
> it is at least an incremental improvement to document that it isn't 
> expected to work as-is on remote host.  And disabling it does get rid of 
> 33 completely bogus FAILs.  :-P
> 
> OK?
> 
> -Sandra
> 

> +# This test has hard-wired assumptions that host and build filenames are
> +# the same, and assumes POSIX pathname syntax.
> +if { [is_remote host] || [ishost *-*-mingw*] } {
> +    return 0
> +}
> +

Should we use "untested" or "unsupported" before returning, to have at least a status
in the logs?  The definition of "unsupported" seems appropriate for this case:

    Declares that a test case depends on some facility that does not exist in the
    testing environment.

From: https://www.gnu.org/software/dejagnu/manual/unsupported-procedure.html

Simon


  reply	other threads:[~2019-08-15  3:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-13 22:29 Sandra Loosemore
2019-08-15  3:13 ` Simon Marchi [this message]
2019-08-15 14:37   ` Sandra Loosemore
2019-08-15 14:48     ` Simon Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=18b00c50-2cc0-b327-a06b-25df81b2f70b@simark.ca \
    --to=simark@simark.ca \
    --cc=gdb-patches@sourceware.org \
    --cc=sandra@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox