Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Simon Marchi <simark@simark.ca>
To: Sandra Loosemore <sandra@codesourcery.com>,
	"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [patch, testsuite] Disable dw2-dir-file-name.exp on remote and/or Windows host
Date: Thu, 15 Aug 2019 14:48:00 -0000	[thread overview]
Message-ID: <2703c95f-a5e8-aedd-78fe-183982be9ec2@simark.ca> (raw)
In-Reply-To: <28ebe7e6-7001-96f2-6926-a52edbff8148@codesourcery.com>

On 2019-08-15 10:37 a.m., Sandra Loosemore wrote:
> 
> I did consider that, but the existing previous bit in that file is just
> 
> # This test can only be run on targets which support DWARF-2 and use gas.
> if {![dwarf2_support]} {
>     return 0
> }
> 
> (which also appears in almost all the other gdb.dwarf2/*.exp files) so I thought it would be locally consistent to just return quietly.  Is the policy to use "untested" for host issues but not target properties, maybe?  I'll do whatever conforms to recommended practice here, of course.

Personally, any time a test is skipped for whatever reason, I'd like to see some "UNTESTED"
or "UNSUPPORTED" in the .sum file, to at least know the test existed and was skipped (along
with the reason), rather than just it being omitted.

I don't know if we have an "official" recommended practice here, this is just my opinion.
The patch LGTM in both cases, so I'll let you choose :).

Simon


      reply	other threads:[~2019-08-15 14:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-13 22:29 Sandra Loosemore
2019-08-15  3:13 ` Simon Marchi
2019-08-15 14:37   ` Sandra Loosemore
2019-08-15 14:48     ` Simon Marchi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2703c95f-a5e8-aedd-78fe-183982be9ec2@simark.ca \
    --to=simark@simark.ca \
    --cc=gdb-patches@sourceware.org \
    --cc=sandra@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox