From: Simon Marchi <simark@simark.ca>
To: Andrew Burgess <andrew.burgess@embecosm.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 1/4] gdb/testsuite: Remove build paths from test names
Date: Fri, 24 Apr 2020 10:00:40 -0400 [thread overview]
Message-ID: <9a81d858-230f-31ce-b514-a31f2a2fb892@simark.ca> (raw)
In-Reply-To: <f599af82ab3b3c65ec85ab256db434dd97df248a.1587663712.git.andrew.burgess@embecosm.com>
On 2020-04-23 1:53 p.m., Andrew Burgess wrote:
> Having paths in test names makes it harder to compare results from
> different builds of GDB.
>
> gdb/testsuite/ChangeLog:
>
> * gdb.btrace/multi-inferior.exp: Avoid paths in test names.
> ---
> gdb/testsuite/ChangeLog | 4 ++++
> gdb/testsuite/gdb.btrace/multi-inferior.exp | 6 ++++--
> 2 files changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/gdb/testsuite/gdb.btrace/multi-inferior.exp b/gdb/testsuite/gdb.btrace/multi-inferior.exp
> index 87a99332e03..fdf889f5ed8 100644
> --- a/gdb/testsuite/gdb.btrace/multi-inferior.exp
> +++ b/gdb/testsuite/gdb.btrace/multi-inferior.exp
> @@ -40,7 +40,8 @@ with_test_prefix "inferior 1" {
> }
>
> with_test_prefix "inferior 2" {
> - gdb_test "add-inferior -exec ${binfile}" "Added inferior 2.*"
> + gdb_test "add-inferior -exec ${binfile}" "Added inferior 2.*" \
> + "add second inferior"
> gdb_test "inferior 2" "Switching to inferior 2.*"
>
> if ![runto_main] {
> @@ -59,7 +60,8 @@ with_test_prefix "inferior 1" {
> }
>
> with_test_prefix "inferior 3" {
> - gdb_test "add-inferior -exec ${binfile}" "Added inferior 3.*"
> + gdb_test "add-inferior -exec ${binfile}" "Added inferior 3.*" \
> + "add third inferior"
> gdb_test "inferior 3" "Switching to inferior 3.*"
>
> if ![runto_main] {
> --
> 2.25.3
>
This LGTM, regardless of the rest of the series.
Simon
next prev parent reply other threads:[~2020-04-24 14:00 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-23 17:53 [PATCH 0/4] Automatic detection of test name problems Andrew Burgess
2020-04-23 17:53 ` [PATCH 1/4] gdb/testsuite: Remove build paths from test names Andrew Burgess
2020-04-24 14:00 ` Simon Marchi [this message]
2020-04-23 17:53 ` [PATCH 2/4] gdb/testsuite: Detect and warn if paths are used in " Andrew Burgess
2020-04-23 20:26 ` Keith Seitz
2020-04-27 15:58 ` Andrew Burgess
2020-04-27 16:42 ` Keith Seitz
2020-04-27 19:06 ` Andrew Burgess
2020-04-23 17:53 ` [PATCH 3/4] gdb/testsuite: Detect and warn about duplicate " Andrew Burgess
2020-04-23 20:28 ` Keith Seitz
2020-04-23 17:53 ` [PATCH 4/4] contrib: Handle GDB specific test result types Andrew Burgess
2020-04-23 20:25 ` [PATCH 0/4] Automatic detection of test name problems Keith Seitz
2020-04-27 22:01 ` [PATCHv2 0/3] " Andrew Burgess
2020-04-27 22:01 ` [PATCHv2 1/3] gdb/testsuite: Detect and warn if paths are used in test names Andrew Burgess
2020-04-27 22:01 ` [PATCHv2 2/3] gdb/testsuite: Detect and warn about duplicate " Andrew Burgess
2020-04-27 22:01 ` [PATCHv2 3/3] contrib: Handle GDB specific test result types Andrew Burgess
2020-04-28 19:08 ` [PATCHv2 0/3] Automatic detection of test name problems Keith Seitz
2020-04-29 9:02 ` Andrew Burgess
2020-04-29 15:04 ` Simon Marchi
2020-04-29 15:38 ` Andrew Burgess
2020-04-29 16:03 ` Keith Seitz
2020-04-29 18:22 ` Simon Marchi
2020-04-30 11:20 ` [PATCHv3 " Andrew Burgess
2020-04-30 11:20 ` [PATCHv3 1/3] gdb/testsuite: Detect and warn if paths are used in test names Andrew Burgess
2020-04-30 11:20 ` [PATCHv3 2/3] gdb/testsuite: Detect and warn about duplicate " Andrew Burgess
2020-07-31 21:34 ` Simon Marchi
2020-08-03 10:02 ` Andrew Burgess
2020-08-03 12:18 ` Simon Marchi
2020-04-30 11:20 ` [PATCHv3 3/3] contrib: Handle GDB specific test result types Andrew Burgess
2020-04-30 18:01 ` [PATCHv3 0/3] Automatic detection of test name problems Tom Tromey
2020-05-11 21:30 ` Andrew Burgess
2020-05-12 16:48 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a81d858-230f-31ce-b514-a31f2a2fb892@simark.ca \
--to=simark@simark.ca \
--cc=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox