From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <simark@simark.ca>
Received: from simark.ca (simark.ca [158.69.221.121])
 by sourceware.org (Postfix) with ESMTPS id 8F42C389366C
 for <gdb-patches@sourceware.org>; Fri, 24 Apr 2020 14:00:44 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 8F42C389366C
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=simark.ca
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca
Received: from [10.0.0.193] (unknown [192.222.164.54])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by simark.ca (Postfix) with ESMTPSA id C95031F3AF;
 Fri, 24 Apr 2020 10:00:40 -0400 (EDT)
Subject: Re: [PATCH 1/4] gdb/testsuite: Remove build paths from test names
To: Andrew Burgess <andrew.burgess@embecosm.com>, gdb-patches@sourceware.org
References: <cover.1587663712.git.andrew.burgess@embecosm.com>
 <f599af82ab3b3c65ec85ab256db434dd97df248a.1587663712.git.andrew.burgess@embecosm.com>
From: Simon Marchi <simark@simark.ca>
Message-ID: <9a81d858-230f-31ce-b514-a31f2a2fb892@simark.ca>
Date: Fri, 24 Apr 2020 10:00:40 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.7.0
MIME-Version: 1.0
In-Reply-To: <f599af82ab3b3c65ec85ab256db434dd97df248a.1587663712.git.andrew.burgess@embecosm.com>
Content-Type: text/plain; charset=utf-8
Content-Language: tl
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-22.8 required=5.0 tests=BAYES_00, GIT_PATCH_0,
 GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_DMARC_STATUS, SPF_HELO_PASS,
 SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <http://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <http://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Fri, 24 Apr 2020 14:00:49 -0000

On 2020-04-23 1:53 p.m., Andrew Burgess wrote:
> Having paths in test names makes it harder to compare results from
> different builds of GDB.
> 
> gdb/testsuite/ChangeLog:
> 
> 	* gdb.btrace/multi-inferior.exp: Avoid paths in test names.
> ---
>  gdb/testsuite/ChangeLog                     | 4 ++++
>  gdb/testsuite/gdb.btrace/multi-inferior.exp | 6 ++++--
>  2 files changed, 8 insertions(+), 2 deletions(-)
> 
> diff --git a/gdb/testsuite/gdb.btrace/multi-inferior.exp b/gdb/testsuite/gdb.btrace/multi-inferior.exp
> index 87a99332e03..fdf889f5ed8 100644
> --- a/gdb/testsuite/gdb.btrace/multi-inferior.exp
> +++ b/gdb/testsuite/gdb.btrace/multi-inferior.exp
> @@ -40,7 +40,8 @@ with_test_prefix "inferior 1" {
>  }
>  
>  with_test_prefix "inferior 2" {
> -    gdb_test "add-inferior -exec ${binfile}" "Added inferior 2.*"
> +    gdb_test "add-inferior -exec ${binfile}" "Added inferior 2.*" \
> +	"add second inferior"
>      gdb_test "inferior 2" "Switching to inferior 2.*"
>  
>      if ![runto_main] {
> @@ -59,7 +60,8 @@ with_test_prefix "inferior 1" {
>  }
>  
>  with_test_prefix "inferior 3" {
> -    gdb_test "add-inferior -exec ${binfile}" "Added inferior 3.*"
> +    gdb_test "add-inferior -exec ${binfile}" "Added inferior 3.*" \
> +	"add third inferior"
>      gdb_test "inferior 3" "Switching to inferior 3.*"
>  
>      if ![runto_main] {
> -- 
> 2.25.3
> 

This LGTM, regardless of the rest of the series.

Simon