From: Keith Seitz <keiths@redhat.com>
To: Andrew Burgess <andrew.burgess@embecosm.com>, gdb-patches@sourceware.org
Subject: Re: [PATCHv2 0/3] Automatic detection of test name problems
Date: Tue, 28 Apr 2020 12:08:25 -0700 [thread overview]
Message-ID: <290d0de3-264b-9a60-487f-ff6b484c35f1@redhat.com> (raw)
In-Reply-To: <cover.1588024848.git.andrew.burgess@embecosm.com>
On 4/27/20 3:01 PM, Andrew Burgess wrote:
> Changes since v1:
>
> 1. Original patch #1 is now merged.
>
> 2. Functionality is now placed inside a namespace.
>
> 3. Better counting for multi-variant test runs, this is inline with
> how Dejagnu's muti-variant result counting works.
>
> 4. Use 'string first' instead of 'regexp'.
>
> 5. Reworded commit message on what is now patch #2.
>
> Further feedback welcome.
Wow, that's almost a complete rewrite! While not what I was really
suggesting, I have to admit, a /big/ smile came to my face while
reading this. It is so nicely done!
Thank you!
Keith
PS. As you know, IANAM, but you are, so I encourage you to approve
your patch. ;-)
next prev parent reply other threads:[~2020-04-28 19:08 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-23 17:53 [PATCH 0/4] " Andrew Burgess
2020-04-23 17:53 ` [PATCH 1/4] gdb/testsuite: Remove build paths from test names Andrew Burgess
2020-04-24 14:00 ` Simon Marchi
2020-04-23 17:53 ` [PATCH 2/4] gdb/testsuite: Detect and warn if paths are used in " Andrew Burgess
2020-04-23 20:26 ` Keith Seitz
2020-04-27 15:58 ` Andrew Burgess
2020-04-27 16:42 ` Keith Seitz
2020-04-27 19:06 ` Andrew Burgess
2020-04-23 17:53 ` [PATCH 3/4] gdb/testsuite: Detect and warn about duplicate " Andrew Burgess
2020-04-23 20:28 ` Keith Seitz
2020-04-23 17:53 ` [PATCH 4/4] contrib: Handle GDB specific test result types Andrew Burgess
2020-04-23 20:25 ` [PATCH 0/4] Automatic detection of test name problems Keith Seitz
2020-04-27 22:01 ` [PATCHv2 0/3] " Andrew Burgess
2020-04-27 22:01 ` [PATCHv2 1/3] gdb/testsuite: Detect and warn if paths are used in test names Andrew Burgess
2020-04-27 22:01 ` [PATCHv2 2/3] gdb/testsuite: Detect and warn about duplicate " Andrew Burgess
2020-04-27 22:01 ` [PATCHv2 3/3] contrib: Handle GDB specific test result types Andrew Burgess
2020-04-28 19:08 ` Keith Seitz [this message]
2020-04-29 9:02 ` [PATCHv2 0/3] Automatic detection of test name problems Andrew Burgess
2020-04-29 15:04 ` Simon Marchi
2020-04-29 15:38 ` Andrew Burgess
2020-04-29 16:03 ` Keith Seitz
2020-04-29 18:22 ` Simon Marchi
2020-04-30 11:20 ` [PATCHv3 " Andrew Burgess
2020-04-30 11:20 ` [PATCHv3 1/3] gdb/testsuite: Detect and warn if paths are used in test names Andrew Burgess
2020-04-30 11:20 ` [PATCHv3 2/3] gdb/testsuite: Detect and warn about duplicate " Andrew Burgess
2020-07-31 21:34 ` Simon Marchi
2020-08-03 10:02 ` Andrew Burgess
2020-08-03 12:18 ` Simon Marchi
2020-04-30 11:20 ` [PATCHv3 3/3] contrib: Handle GDB specific test result types Andrew Burgess
2020-04-30 18:01 ` [PATCHv3 0/3] Automatic detection of test name problems Tom Tromey
2020-05-11 21:30 ` Andrew Burgess
2020-05-12 16:48 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=290d0de3-264b-9a60-487f-ff6b484c35f1@redhat.com \
--to=keiths@redhat.com \
--cc=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox