From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) by sourceware.org (Postfix) with ESMTP id CAB883851C09 for ; Tue, 28 Apr 2020 19:08:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org CAB883851C09 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-314-4fdtSIq5M4KBT-t0Pkt03g-1; Tue, 28 Apr 2020 15:08:27 -0400 X-MC-Unique: 4fdtSIq5M4KBT-t0Pkt03g-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E366B108BD0C; Tue, 28 Apr 2020 19:08:26 +0000 (UTC) Received: from theo.uglyboxes.com (ovpn-112-88.phx2.redhat.com [10.3.112.88]) by smtp.corp.redhat.com (Postfix) with ESMTPS id ABEB8648D7; Tue, 28 Apr 2020 19:08:26 +0000 (UTC) Subject: Re: [PATCHv2 0/3] Automatic detection of test name problems To: Andrew Burgess , gdb-patches@sourceware.org References: From: Keith Seitz Message-ID: <290d0de3-264b-9a60-487f-ff6b484c35f1@redhat.com> Date: Tue, 28 Apr 2020 12:08:25 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Apr 2020 19:08:30 -0000 On 4/27/20 3:01 PM, Andrew Burgess wrote: > Changes since v1: > > 1. Original patch #1 is now merged. > > 2. Functionality is now placed inside a namespace. > > 3. Better counting for multi-variant test runs, this is inline with > how Dejagnu's muti-variant result counting works. > > 4. Use 'string first' instead of 'regexp'. > > 5. Reworded commit message on what is now patch #2. > > Further feedback welcome. Wow, that's almost a complete rewrite! While not what I was really suggesting, I have to admit, a /big/ smile came to my face while reading this. It is so nicely done! Thank you! Keith PS. As you know, IANAM, but you are, so I encourage you to approve your patch. ;-)