Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Andrew Burgess <andrew.burgess@embecosm.com>, gdb-patches@sourceware.org
Cc: Jim Wilson <jimw@sifive.com>, Palmer Dabbelt <palmer@sifive.com>
Subject: Re: [PATCH] gdb/riscv: Don't error when decoding a 6 or 8 byte instruction
Date: Wed, 05 Jun 2019 09:12:00 -0000	[thread overview]
Message-ID: <998212a3-4a1d-12ad-2a16-aa05a0e4101c@redhat.com> (raw)
In-Reply-To: <20190604115054.25306-1-andrew.burgess@embecosm.com>

On 6/4/19 12:50 PM, Andrew Burgess wrote:
> +	   prologue scanner will try to decode it.  These long
> +	   instructions are ISA extensions, I use .byte rather than an
> +	   actual instruction mnemonic so that the test can be compiled

Tiny nit, but please avoid "I" in comments.  Either just don't use a
pronoun, e.g.:

   Since these long instructions are ISA extensions, use .byte

or use "we" instead.

Thanks,
Pedro Alves


  parent reply	other threads:[~2019-06-05  9:12 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-04 11:51 Andrew Burgess
2019-06-04 16:36 ` John Baldwin
2019-06-04 23:49 ` Palmer Dabbelt
2019-06-05  9:08 ` Andrew Burgess
2019-06-05  9:12 ` Pedro Alves [this message]
2019-06-05  9:38   ` Andrew Burgess

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=998212a3-4a1d-12ad-2a16-aa05a0e4101c@redhat.com \
    --to=palves@redhat.com \
    --cc=andrew.burgess@embecosm.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jimw@sifive.com \
    --cc=palmer@sifive.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox