From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 43668 invoked by alias); 5 Jun 2019 09:12:17 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 43656 invoked by uid 89); 5 Jun 2019 09:12:17 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy= X-HELO: mail-wr1-f53.google.com Received: from mail-wr1-f53.google.com (HELO mail-wr1-f53.google.com) (209.85.221.53) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 05 Jun 2019 09:12:16 +0000 Received: by mail-wr1-f53.google.com with SMTP id n4so13398357wrw.13 for ; Wed, 05 Jun 2019 02:12:15 -0700 (PDT) Return-Path: Received: from ?IPv6:2001:8a0:f913:f700:4eeb:42ff:feef:f164? ([2001:8a0:f913:f700:4eeb:42ff:feef:f164]) by smtp.gmail.com with ESMTPSA id a139sm31497343wmd.18.2019.06.05.02.12.13 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Wed, 05 Jun 2019 02:12:13 -0700 (PDT) Subject: Re: [PATCH] gdb/riscv: Don't error when decoding a 6 or 8 byte instruction To: Andrew Burgess , gdb-patches@sourceware.org References: <20190604115054.25306-1-andrew.burgess@embecosm.com> Cc: Jim Wilson , Palmer Dabbelt From: Pedro Alves Message-ID: <998212a3-4a1d-12ad-2a16-aa05a0e4101c@redhat.com> Date: Wed, 05 Jun 2019 09:12:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20190604115054.25306-1-andrew.burgess@embecosm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2019-06/txt/msg00117.txt.bz2 On 6/4/19 12:50 PM, Andrew Burgess wrote: > + prologue scanner will try to decode it. These long > + instructions are ISA extensions, I use .byte rather than an > + actual instruction mnemonic so that the test can be compiled Tiny nit, but please avoid "I" in comments. Either just don't use a pronoun, e.g.: Since these long instructions are ISA extensions, use .byte or use "we" instead. Thanks, Pedro Alves