From: John Baldwin <jhb@FreeBSD.org>
To: Andrew Burgess <andrew.burgess@embecosm.com>, gdb-patches@sourceware.org
Cc: Jim Wilson <jimw@sifive.com>, Palmer Dabbelt <palmer@sifive.com>
Subject: Re: [PATCH] gdb/riscv: Don't error when decoding a 6 or 8 byte instruction
Date: Tue, 04 Jun 2019 16:36:00 -0000 [thread overview]
Message-ID: <644e82ee-6c4e-f01a-4cd7-f202b327366d@FreeBSD.org> (raw)
In-Reply-To: <20190604115054.25306-1-andrew.burgess@embecosm.com>
On 6/4/19 4:50 AM, Andrew Burgess wrote:
> If the RISC-V prologue scanner finds a 6 or 8 byte instruction we
> currently throw an internal error, which is not great for the user.
>
> A mechanism already exists in the prologue scanner to leave
> instructions marked as unknown so that we can stop the prologue scan
> without raising an error, this is used for all 2 and 4 byte
> instructions that are not part of the small set the prologue scanner
> actually understands.
>
> This commit changes GDB so that all 6 and 8 byte instructions are
> marked as unknown, rather than causing an error.
Looks good to me.
--
John Baldwin
next prev parent reply other threads:[~2019-06-04 16:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-04 11:51 Andrew Burgess
2019-06-04 16:36 ` John Baldwin [this message]
2019-06-04 23:49 ` Palmer Dabbelt
2019-06-05 9:08 ` Andrew Burgess
2019-06-05 9:12 ` Pedro Alves
2019-06-05 9:38 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=644e82ee-6c4e-f01a-4cd7-f202b327366d@FreeBSD.org \
--to=jhb@freebsd.org \
--cc=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
--cc=jimw@sifive.com \
--cc=palmer@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox