From: Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
To: Tom de Vries <tdevries@suse.de>,
Simon Marchi <simon.marchi@efficios.com>,
gdb-patches@sourceware.org
Subject: Re: [PATCH v2 3/3] gdb: introduce scoped debug prints
Date: Tue, 5 Jan 2021 10:33:09 -0500 [thread overview]
Message-ID: <97ef7c08-c281-963e-96ba-0ba64a123980@polymtl.ca> (raw)
In-Reply-To: <66ff5e72-f002-ed4f-075a-3054d17e7862@suse.de>
On 2021-01-05 4:23 a.m., Tom de Vries wrote:
> On 1/5/21 10:01 AM, Tom de Vries wrote:
>> [ I first tried to override $gdb_prompt for the duration of
>> gdb_test_sequence using save_vars, but there's the invariant that the
>> gdb_prompt variable has an implicit " " after it, which
>> gdb_test_sequence adds, so that didn't work. ]
>
> So, if we introduce a variable gdb_prompt_full which does contain the
> space, and use it in gdb_test_sequence, we can override it.
>
> Thanks,
> - Tom
>
Thanks for reporting. The test passes here 90% of the time, but when I
run it in a loop it eventually fails like the others I fixed.
I'd rather add a -prompt flag to gdb_test_sequence, what do you think?
I'll start working on that and give it a try.
Simon
next prev parent reply other threads:[~2021-01-05 15:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-16 20:47 [PATCH v2 1/3] gdb: make "set debug timestamp" work nice with new debug printouts Simon Marchi via Gdb-patches
2020-12-16 20:47 ` [PATCH v2 2/3] gdb: use infrun_debug_printf in print_target_wait_results Simon Marchi via Gdb-patches
2020-12-16 20:47 ` [PATCH v2 3/3] gdb: introduce scoped debug prints Simon Marchi via Gdb-patches
2020-12-22 21:35 ` Simon Marchi via Gdb-patches
2021-01-04 17:02 ` Simon Marchi via Gdb-patches
2021-01-05 9:01 ` Tom de Vries
2021-01-05 9:23 ` Tom de Vries
2021-01-05 15:33 ` Simon Marchi via Gdb-patches [this message]
2021-01-05 17:02 ` Simon Marchi via Gdb-patches
2021-01-05 21:26 ` tdevries
2021-01-05 21:54 ` Simon Marchi via Gdb-patches
2021-01-06 1:00 ` Simon Marchi via Gdb-patches
2021-01-06 7:15 ` Tom de Vries
2021-01-06 19:05 ` Simon Marchi via Gdb-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=97ef7c08-c281-963e-96ba-0ba64a123980@polymtl.ca \
--to=gdb-patches@sourceware.org \
--cc=simon.marchi@efficios.com \
--cc=simon.marchi@polymtl.ca \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox