From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id IeOrEsCG9F/MQQAAWB0awg (envelope-from ) for ; Tue, 05 Jan 2021 10:33:20 -0500 Received: by simark.ca (Postfix, from userid 112) id 42A1D1E590; Tue, 5 Jan 2021 10:33:20 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_NONE,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (unknown [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id E4C601E590 for ; Tue, 5 Jan 2021 10:33:19 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 996123938C0C; Tue, 5 Jan 2021 15:33:19 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 996123938C0C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1609860799; bh=+GG83iXQZqpSgXDTQCFYv7NG3iTmATaj7+9d7o621kg=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=ujANU+ObGH1E/eEUeB+43QbvI3FbIK7T/C2uyfO2HJV8Gz8skUaH+uovSyS97FeEZ evCYsHiUqAJbzFiMBf4BFenHymGXLNIAjaqCW8GKowSAPnjsk20KrSxKMB0/KGBjDA 6gdQ6X2sPOWeVNdFeGOWTcLQrCKpsSCCa5fPc1qI= Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id D0A5B393839B for ; Tue, 5 Jan 2021 15:33:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org D0A5B393839B Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 105FXAEm017228 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 5 Jan 2021 10:33:15 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 105FXAEm017228 Received: from [10.0.0.213] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 0FFBA1E590; Tue, 5 Jan 2021 10:33:10 -0500 (EST) Subject: Re: [PATCH v2 3/3] gdb: introduce scoped debug prints To: Tom de Vries , Simon Marchi , gdb-patches@sourceware.org References: <20201216204737.900975-1-simon.marchi@efficios.com> <20201216204737.900975-3-simon.marchi@efficios.com> <3ad3b11f-8a72-cd1d-a138-59c47300f147@polymtl.ca> <66ff5e72-f002-ed4f-075a-3054d17e7862@suse.de> Message-ID: <97ef7c08-c281-963e-96ba-0ba64a123980@polymtl.ca> Date: Tue, 5 Jan 2021 10:33:09 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <66ff5e72-f002-ed4f-075a-3054d17e7862@suse.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Tue, 5 Jan 2021 15:33:10 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 2021-01-05 4:23 a.m., Tom de Vries wrote: > On 1/5/21 10:01 AM, Tom de Vries wrote: >> [ I first tried to override $gdb_prompt for the duration of >> gdb_test_sequence using save_vars, but there's the invariant that the >> gdb_prompt variable has an implicit " " after it, which >> gdb_test_sequence adds, so that didn't work. ] > > So, if we introduce a variable gdb_prompt_full which does contain the > space, and use it in gdb_test_sequence, we can override it. > > Thanks, > - Tom > Thanks for reporting. The test passes here 90% of the time, but when I run it in a loop it eventually fails like the others I fixed. I'd rather add a -prompt flag to gdb_test_sequence, what do you think? I'll start working on that and give it a try. Simon