Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
To: Simon Marchi <simon.marchi@efficios.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH v2 3/3] gdb: introduce scoped debug prints
Date: Mon, 4 Jan 2021 12:02:07 -0500	[thread overview]
Message-ID: <3ad3b11f-8a72-cd1d-a138-59c47300f147@polymtl.ca> (raw)
In-Reply-To: <f5d68889-3c4b-b887-3108-2b841dd5066e@polymtl.ca>


> With this patch, gdb.threads/stepi-random-signal.exp becomes flaky.  I folded
> this little fixup in the patch:
> 
> commit 49c94827cbbe802726f177bc61c6c9d830907ffa
> Author: Simon Marchi <simon.marchi@polymtl.ca>
> Date:   Tue Dec 22 16:33:40 2020 -0500
> 
>     fixup
>     
>     Change-Id: Ibd2f622df3e76c873fcf82bca7c4c7900654647e
> 
> diff --git a/gdb/testsuite/gdb.threads/stepi-random-signal.exp b/gdb/testsuite/gdb.threads/stepi-random-signal.exp
> index 9a8b38c2acf5..689de8fdc632 100644
> --- a/gdb/testsuite/gdb.threads/stepi-random-signal.exp
> +++ b/gdb/testsuite/gdb.threads/stepi-random-signal.exp
> @@ -86,12 +86,13 @@ if {$prev_addr == ""} {
>  set seen 0
>  
>  set test "stepi"
> -if {[gdb_test_multiple "stepi" "$test" {
> +set prompt "$gdb_prompt \\\[infrun\\\] fetch_inferior_event: exit\r\n$"
> +if {[gdb_test_multiple "stepi" "$test" -prompt $prompt {
>      -re {\[infrun\] handle_signal_stop: random signal} {
>  	set seen 1
>  	exp_continue
>      }
> -    -re "$gdb_prompt $" {
> +    -re "$prompt$" {
>      }
>  }] != 0} {
>      return
> 
> 
> Simon
> 


I pushed this series, including this fix.

Simon

  reply	other threads:[~2021-01-04 17:02 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-16 20:47 [PATCH v2 1/3] gdb: make "set debug timestamp" work nice with new debug printouts Simon Marchi via Gdb-patches
2020-12-16 20:47 ` [PATCH v2 2/3] gdb: use infrun_debug_printf in print_target_wait_results Simon Marchi via Gdb-patches
2020-12-16 20:47 ` [PATCH v2 3/3] gdb: introduce scoped debug prints Simon Marchi via Gdb-patches
2020-12-22 21:35   ` Simon Marchi via Gdb-patches
2021-01-04 17:02     ` Simon Marchi via Gdb-patches [this message]
2021-01-05  9:01       ` Tom de Vries
2021-01-05  9:23         ` Tom de Vries
2021-01-05 15:33           ` Simon Marchi via Gdb-patches
2021-01-05 17:02             ` Simon Marchi via Gdb-patches
2021-01-05 21:26               ` tdevries
2021-01-05 21:54                 ` Simon Marchi via Gdb-patches
2021-01-06  1:00                   ` Simon Marchi via Gdb-patches
2021-01-06  7:15                     ` Tom de Vries
2021-01-06 19:05                       ` Simon Marchi via Gdb-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3ad3b11f-8a72-cd1d-a138-59c47300f147@polymtl.ca \
    --to=gdb-patches@sourceware.org \
    --cc=simon.marchi@efficios.com \
    --cc=simon.marchi@polymtl.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox