From: Simon Marchi <simon.marchi@efficios.com>
To: Guinevere Larsen <guinevere@redhat.com>,
simon.marchi@polymtl.ca, gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb/dwarf: rename dwarf2_per_cu_data -> dwarf2_per_cu
Date: Wed, 26 Feb 2025 12:02:54 -0500 [thread overview]
Message-ID: <97eeac2f-66e0-45b2-9325-cef7c821c63a@efficios.com> (raw)
In-Reply-To: <6d8a6af5-56f3-497b-b964-78a24c309087@redhat.com>
On 2/26/25 9:50 AM, Guinevere Larsen wrote:
> On 2/26/25 1:20 AM, simon.marchi@polymtl.ca wrote:
>> From: Simon Marchi <simon.marchi@efficios.com>
>>
>> This scratches an itch I had for a while. I don't know why this struct
>> type has "data" in its name. Others like "dwarf2_per_objfile" and
>> "dwarf2_per_bfd" don't. The primary job of a structure is to hold data,
>> there's no need to specify it. It also makes the name a bit shorter,
>> which is always nice.
>>
>> Rename related types too.
>>
>> Change-Id: Ifb63195ff105809fc15b502f639c0bb4d18a675e
>
> I took a look over the patch and ran a quick test, everything looks ok, and this is a good change!
>
> Reviewed-By: Guinevere Larsen <guinevere@redhat.com>
Thanks for reviewing. I'll wait for an ack from Tom Tromey, as the
de facto DWARF subsystem maintainer.
Simon
next prev parent reply other threads:[~2025-02-26 17:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-26 4:20 simon.marchi
2025-02-26 14:50 ` Guinevere Larsen
2025-02-26 17:02 ` Simon Marchi [this message]
2025-03-03 20:32 ` Tom Tromey
2025-03-03 20:55 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=97eeac2f-66e0-45b2-9325-cef7c821c63a@efficios.com \
--to=simon.marchi@efficios.com \
--cc=gdb-patches@sourceware.org \
--cc=guinevere@redhat.com \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox