From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 39DnM2FJv2ehmj4AWB0awg (envelope-from ) for ; Wed, 26 Feb 2025 12:03:29 -0500 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=efficios.com header.i=@efficios.com header.a=rsa-sha256 header.s=selector1 header.b=BwAj9A9+; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id C55F41E105; Wed, 26 Feb 2025 12:03:29 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id B388F1E05C for ; Wed, 26 Feb 2025 12:03:28 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 520803858D35 for ; Wed, 26 Feb 2025 17:03:28 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 520803858D35 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=efficios.com header.i=@efficios.com header.a=rsa-sha256 header.s=selector1 header.b=BwAj9A9+ Received: from YT6PR01CU002.outbound.protection.outlook.com (mail-canadacentralazlp170120003.outbound.protection.outlook.com [IPv6:2a01:111:f403:c103::3]) by sourceware.org (Postfix) with ESMTPS id 7CD873858D26 for ; Wed, 26 Feb 2025 17:02:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7CD873858D26 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=efficios.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=efficios.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7CD873858D26 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=2a01:111:f403:c103::3 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1740589378; cv=pass; b=J5x5CpsbuhThF5BpfD8U1biraLalkTpwsYf0OWZ5T0YIxwt1gy+5xnRnab3bSmQlEeROMbIhCGPpvrOFzZVty/D1yq10S6VPDs+8UoARoT8duzrh0PgBtBppl55+h5yKuKYKynz/3dkTPH/uCQ2dFNY/owj5ljYDbh1C34QcJgs= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1740589378; c=relaxed/simple; bh=Wls48Dx9ql1nB/atAhtZB6PwNN1DlQmHX9RafWcSx3I=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=AW7IoxSzhRQB0jB3fZOC3jevwThpJdBUj3LQT850ehKFku8StXElA/wPKJ1ZSy47CsiYsZK3eVZqxYGfsjM7RO/y4niCCfdYg71X+j/NKCD7P0PJVwrQV0Gy4LWB3a9KZjplEJI211cgr9gGINFVAAydQ+aUb+KSEF3FaMydIS0= ARC-Authentication-Results: i=2; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7CD873858D26 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=lFKVTVb6+5JIaMsXJ04ZCzxk/9rEQqnXRuAChn82E3o3MYUpVQTGQujNfZaF2B8j5UJkuC7uJor2bHP/5GPzSR5GwzZy7ipzB9M9hfXer+xkdhcO1qDh+JJs8CTl/zn10keetdRxwXIUrHccBf7pItiof/mTNmqDj+D2RMSEjoWjX4Rua60rer+J/tyL63Wc9nMjErlZtX6at+Z8Jn021VAnO7rXfGkonpPGpYP4jnsYsMcsZSqIepldVhQavhuQ3NUyRFrJzje9GL0pqH1wsELhFy8G/hXOgKgvGQSgiEuPLPXCf7wbIOc7xtb1uLCgXw8aJ5iM18eLS1dWWpQ82g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zgWRTG+Y94g2E9KNV5xdbFOai+7BDCxctVakQ7eARIs=; b=nSWiuS/LHa3KM6A9M1vRwLKN84XiOe1XWGBPDSPmQ9H9ikTZfITXY+I3/IUDt6OfIs+aBncpnT7YqgzBMfNUmQBdO5xOXLhYcoMSDBplqPlVC2vi8AxnSo2NNZEegYP1kaE1gOTUYOiKliB8+/mHmux8H1CkLfJR1HE0VFdAP9/TvdXi5ItgI0KyeAAlA6AeYb1KSthJNOyloPn5bDK9N5tuWZLOXKouHksKB9my3MnUmPpSQPYlKt3BhhfVlBZsEdZE50atXJZSnaTH5eO8sbbj5xw7XAjN0kH/1bb217tzkjHSE+MhVO5/Tdw2MTi2Fc8MpyzadR+te9suzXMI7A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=efficios.com; dmarc=pass action=none header.from=efficios.com; dkim=pass header.d=efficios.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficios.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zgWRTG+Y94g2E9KNV5xdbFOai+7BDCxctVakQ7eARIs=; b=BwAj9A9+S1YADYUNuGcrQfukcuiLuLoYTzvwX1+8wTQh7inEJF8/DOeAAFO8hgCaEKEW6kSlK4gLfIihpPPBYcUu1iKT+o44zsNfmbNBusKhQzoLM1+MH2NUzfyl46MrJZT0wAYH0y6W7cO4zeDg/570OOqQp5NcftpZvvHdzJKyePCzMoFD6/oxIPMldPXMBljnp6FJm6AI9qtynBUIWiyKcieNUL1f2xIF9vui/X/GVfH/OnVfdHZSdaNl/gQj0LlRKI9KFB/vZbZDvB1tQguEoaK6A3kIOYTaBYumKdWyLQ1kJiHKhnmevASTVM10OGfyWA24W8AjsnsUHbcF8g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=efficios.com; Received: from TO1PPF18EA7E37A.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b08::618) by YT2PR01MB8727.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:ba::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8489.18; Wed, 26 Feb 2025 17:02:56 +0000 Received: from TO1PPF18EA7E37A.CANPRD01.PROD.OUTLOOK.COM ([fe80::8dc4:28bd:6015:75cb]) by TO1PPF18EA7E37A.CANPRD01.PROD.OUTLOOK.COM ([fe80::8dc4:28bd:6015:75cb%7]) with mapi id 15.20.8489.019; Wed, 26 Feb 2025 17:02:56 +0000 Message-ID: <97eeac2f-66e0-45b2-9325-cef7c821c63a@efficios.com> Date: Wed, 26 Feb 2025 12:02:54 -0500 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gdb/dwarf: rename dwarf2_per_cu_data -> dwarf2_per_cu To: Guinevere Larsen , simon.marchi@polymtl.ca, gdb-patches@sourceware.org References: <20250226042042.2267150-1-simon.marchi@polymtl.ca> <6d8a6af5-56f3-497b-b964-78a24c309087@redhat.com> Content-Language: fr From: Simon Marchi In-Reply-To: <6d8a6af5-56f3-497b-b964-78a24c309087@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: YQBP288CA0030.CANP288.PROD.OUTLOOK.COM (2603:10b6:c01:9d::28) To TO1PPF18EA7E37A.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b08::618) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: TO1PPF18EA7E37A:EE_|YT2PR01MB8727:EE_ X-MS-Office365-Filtering-Correlation-Id: 4b0d1cc8-db0a-46de-1898-08dd56876a38 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|366016|7053199007; X-Microsoft-Antispam-Message-Info: =?utf-8?B?bWNta0xYWXV1UENOaFBmSjA0RFlkc29sa3BpaEVwWHZ1QVlxNW90WHVEUm8r?= =?utf-8?B?Zi9tMmdINnJKZjNIRDVCMjRUNk1TR2IzTWpHRXliTkw3YzR4cDFrZjBleFo0?= =?utf-8?B?S0JjZnkrTXlVN0tkTHZmc2F2YjMyZzVNWGVEemRwdVBIYzZBREZtQjZEWUhi?= =?utf-8?B?Q1VnN3Z3M2VxbU8rWkZUU0dLRThLQzAxMm9DR2lCU08zYjhPMmFZN0R0dG43?= =?utf-8?B?RkR2OWJ6cHNyd1BZT1FJOStZZ3MyeXFRWCtNV3FNZ1FHWmJYUDRCWERTQjVV?= =?utf-8?B?VmdDUk9lRHJvc3pxUzEvS29ZbWFITENXd3l5cHJpYUpYT2pPeFM4TXdMOWVp?= =?utf-8?B?UXdONC85TTlXTnB1YkNSWVRYa3BHMHpybFV5Q0ZwRGl6MEpTdlNkMFoyUWo5?= =?utf-8?B?bnNKcjdsVUhIb1ZjdWhjSkRmVldvZXpQS2VOb2FXNy9HSlZxa0lkTSs3a0dv?= =?utf-8?B?RDZVTE9oTjJNbnNaVUdDdG1sQkdZR1VkNFpWT2tIdWhDNmhkVWpiV0xtTHpu?= =?utf-8?B?NXRzOFgwb0ZzNGZoc0l4Vm92emdxekVjUjMwS1JrSXBQemRmcUZETlFDTVFn?= =?utf-8?B?ZzFGdmNsYVV4dEsydUs5SzExUGl1MEZYNkd4VHVmZk5MZnZ3TFF1V09nSnJK?= =?utf-8?B?L2RFOFNPc0QzdktmTjdTME1KcjkvUWNlcFVCR1VzQUtiZ0g3Yis1anM3OUU1?= =?utf-8?B?RkVMdTk1aEhYenlibU90ZHpIeGY1S0h3eU9ndFVBRnlPdElJM0ZaOGVZNHYy?= =?utf-8?B?YU5xUjUxd1NicUUvZEtBRk5hSURuZitabkFxS20vWHk0RHU5UG1VRzlKU1U4?= =?utf-8?B?U3hXT3FraHo0M2FXbys3ZHBQQ0tydXBpbjBlUml3Yk10QUhXZkRCT1VUU1pl?= =?utf-8?B?Ly9pMkpPVmxyR0N5RG1MQUlzUURBZ3M5STdGQ0gxVFhJOGlueDhYVGNZS1dZ?= =?utf-8?B?RjgrVDYxblZ0a2lNUUR1ZmJpVm1yeUl0Z09FNmoxVjFZeEpRQlFaQ1NKQkZo?= =?utf-8?B?ZTlySHQwMndweVc2QXlsWEVNVGVOTUZYVnd5bW5WUmNXRDRPamxlbGdsdFVw?= =?utf-8?B?T0U1YTN4aFc5Y0tsMmNVV2EwUmRPNHQ0eHRaLzhwYjBOWW1BcWhBWmVWMG5G?= =?utf-8?B?UEw4ODZ4QmlzbjdZUTV3RzdHMnplT0hKSXAvYll2cXBjRmZqdlZDODVicGNS?= =?utf-8?B?YVczZkF1Vk10bVBCWmpiZFh5dnVQY0xFaC9FR21FMkg0WlgwNEkrd1ZDZFJl?= =?utf-8?B?aXBmUzZsN3lUc3dYbEdKK3N4ZmI2VkVCb3pxblM3Wno0cmhic3RnNTg5d0dO?= =?utf-8?B?dDdDeEZVWVI5c3dVNVd3c0UraVNoMkE3aTdCT2lySmppMGhzV1F5SlNndlB2?= =?utf-8?B?TlA1cVFsd3cwalBDMWZNR0t0MUdXZ3NSa3ZCbVV4MnRoM1lmczIrRTc5d2tw?= =?utf-8?B?aFV1bTZPTTB0K1hGSWczeEgzWkFnSjlSNDhjMzBFT21HWjRJbVZmaUhRWnFB?= =?utf-8?B?ckptV3BMUExxOXRZQXQvdldCNjlTcHNFRlRaTU1vbVlJYmhqUUNpSTdVRDFn?= =?utf-8?B?THdSQ1dNam1FYmNyTUYwWDd1RUF1Rk92VXZPckgrR2JLQnh4b1Zwa3BSWWw0?= =?utf-8?B?WHJWOTBoU1F6K283QVM0RDFkZThKcXJoWDUvOVpHQTlBaUdrMzNYNit2UlU5?= =?utf-8?B?YmJtZTgrYlIrTU4yNTdJcXoyNkljSGhTMlN4T2pCZEpTNHViN1lMWE1IOVdL?= =?utf-8?B?NzJoZ01RNjZTU3ByMjQzRXMwRjlTZHBmQjc2OExsZWVxakpteUFGMnc2UFFo?= =?utf-8?B?S3RYc2N0d2gvSFZETFNNRXZpRU9OME9YeFJmb2FsUjNYZ0ZGUlYxMFhzRTY1?= =?utf-8?Q?Fjye/Uy4+zPeq?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:TO1PPF18EA7E37A.CANPRD01.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230040)(376014)(1800799024)(366016)(7053199007); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OElDUVhJbmowcHJycG9pNlFsSlA2QThGYkM5Z0NESkpjM1Zoak1RRnZtK2Uv?= =?utf-8?B?WG5FK093bTJ4RUYzVWIySlVpcStRQjRKa0UwSXh5STBmUjhQQWt2QkhZN3py?= =?utf-8?B?YkprQ2pLQXU3akNCVEhQQVdPeFNzQjhIazdud1BPaVFKekRkUnNuYWhPRm5V?= =?utf-8?B?UmUyaU9aUGt6SlNyV01EdVo0V0NxV09pc0hrYjF3SzBhOHBDem9GSFI5eXVs?= =?utf-8?B?QWJLZE1Td3Z4RmlBeUpFelhKdklKUGZyU1REamNmdmVtb3pkWUlqRE1nYVNa?= =?utf-8?B?Nm9KZ3VHbXZBRnduNTFzUmM4MjZ0K0hoaE5RemZFbkZOSWJTMjdhRVZXUHJJ?= =?utf-8?B?RWhyY1dRSlNXSllER2h1MUI1VVB6ZjB6d3BzS05xRFZwZ09vbVZwYStOenZt?= =?utf-8?B?ZHFJcGNSakg4dUdyaGs0QlRnQjBSREZabXNtQlMwd0dBNzNhQzlzRmVFaWlW?= =?utf-8?B?VHZEOXlKZnhYMkdLVHVRWEVwVTZSUHNUV3lJUXZwdnBhaWM1T3dnYTNHR29F?= =?utf-8?B?VFNEUUU1TjV4elNmWkRrbjRtWElmT2dZVkVialNFcktoUGROT2tNZUN2K0ln?= =?utf-8?B?NTdzWDFVbzZUWDI3Ymd0eXZzamhBYy9MM2Uzay9kdEZ2VnNIQkF3NHRjUFNT?= =?utf-8?B?bkxsNzMxMnUrNmQrVldmMncrdjN6TWpTWVZBRnhucFdHZXJqZHR3RVdmaDBj?= =?utf-8?B?WEtMczUvQ2w2dFhEcVJ1VG1YVWd3V1VUSkROSFVOOWhybzNKZnZkYzZNZmhm?= =?utf-8?B?M0NmRS84eC9OSCtKOVBFU3luaGNOa2c3TDdyTWRnNFVtdkxJR0xtMG1OWVpJ?= =?utf-8?B?T0xEOC9FUUUyVXF3MXZFNkp6ZDk3Y1VDL21LaVp0UGUyMXhVM09pTTUya2Z3?= =?utf-8?B?Y2pkUHgvZmNJUWJvNWlvZ2RWYzFvNWs5cGFFZ1c2eFZFZUI3ZmtVY3drMVcx?= =?utf-8?B?bE9UUmgzU2MzdldmbWR5aFRvdnlCTDRYTjBoUlV0WVNtRkVGblFsTzVma0dU?= =?utf-8?B?TTkzRXVuNWtKVkVBcTFvWEQzbFFSZUxhTEpTWTN2dy96YmpUZEJhU0pST0ov?= =?utf-8?B?alRYU0IwakwzVkl6N29XNzNjam5ZYTlVdDR3VVhjczhtTFA0Wmtwak5RZFFL?= =?utf-8?B?QTdOWE14RHh6YkI5YUhsdlpxdnhzTktjSm5xeVN1eHBncTRJb1p2a0tYZnFZ?= =?utf-8?B?VWY0NGtCOW5jQmxFNVBYcHJkT0JaOWR5WENNSEc5bzRGSy9qV25sUzdwT05L?= =?utf-8?B?T0pBd0MzU21NUTZRck5wWG90UVV0Sm5nbld1UnUwNDdiZWt6OXlmbmhxYWw1?= =?utf-8?B?bVRYMThPcGl0Zy9Ob3RYVHNvSE9qTnREU1d0d3JFM0FsUGgyQlphNWFNb0Fn?= =?utf-8?B?dHNlZDFFcnE1REF4ZSt4V01kalBKcjZic21nSDd2VEFNT0hHVTFBT3cwUmFq?= =?utf-8?B?VGc0aDZ3dHFPbG9QVzExM2lDYWdzbSs2WlpPcFl5Q0w2eHdTaFh2dVBTdkZX?= =?utf-8?B?Tkg5S0pBMWQ0elI5c0R5RDFhNDdZb3JiUmJKNUNXdEcwTmFGeVBLZHBITXFO?= =?utf-8?B?aVJkcSs3b0ZMWUNPN202WHVXOEoxQnF1REFVWlhVeE5ubnJJMWQ2YUdwK2U1?= =?utf-8?B?b3F5NVBaeWdBckxOaEF6aWNrSExnRis5dUFLL0YyV0xpNVhaaWVrUDMycEhv?= =?utf-8?B?bkI5d1NINnp4L2V1MzdJQ2J1RldxU0F4c0c2TUdnVUxkWlRhSE1nem5MYXAr?= =?utf-8?B?T0ptQXFNRWVhMjB2MlFWQUhXbGlQdHVLMGY0NjJtOHFoS1NQa3dMWWhZWVov?= =?utf-8?B?NHBTcEZMS3hFT2VVT3RWYWN6bkxKY0NacWlsYjFYS2krVjdrbTBLbjJkempz?= =?utf-8?B?MjVzVXFjZDgvcUZmSk1zZ0JkcEZHdkJwcWQzTjRBZVdnN3Q4OFFNZWU0akFm?= =?utf-8?B?d0ZTMCt5ZkQyNU1WYnRhS3M1MHJLWWlFK3FGd2FsMHhqaGhBdjc0cWtRQnBY?= =?utf-8?B?R3A5TU9uTlhxMXVUa0pTM2JoTE1HNW9LYU1ULzBlSm5CMExFN3E2VktIemZr?= =?utf-8?B?b2Yyb3U2cG1jNUFxZzEyVUIvQk9lZUtCenpObm5INk92VG5yTGpuNmg5dytL?= =?utf-8?Q?T6WHoIjrapAx/qEeLTPQjt3Ks?= X-OriginatorOrg: efficios.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4b0d1cc8-db0a-46de-1898-08dd56876a38 X-MS-Exchange-CrossTenant-AuthSource: TO1PPF18EA7E37A.CANPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Feb 2025 17:02:56.1043 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4f278736-4ab6-415c-957e-1f55336bd31e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: fzCcm5QOYqzeJIZz1IDLTWlW3zPWDAoEUIEbtyit/8CZ8e08g2YCPFKTJxDMNgo8p4PTTXVE7nn+qMrnvA6dnA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: YT2PR01MB8727 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 2/26/25 9:50 AM, Guinevere Larsen wrote: > On 2/26/25 1:20 AM, simon.marchi@polymtl.ca wrote: >> From: Simon Marchi >> >> This scratches an itch I had for a while. I don't know why this struct >> type has "data" in its name. Others like "dwarf2_per_objfile" and >> "dwarf2_per_bfd" don't. The primary job of a structure is to hold data, >> there's no need to specify it. It also makes the name a bit shorter, >> which is always nice. >> >> Rename related types too. >> >> Change-Id: Ifb63195ff105809fc15b502f639c0bb4d18a675e > > I took a look over the patch and ran a quick test, everything looks ok, and this is a good change! > > Reviewed-By: Guinevere Larsen Thanks for reviewing. I'll wait for an ack from Tom Tromey, as the de facto DWARF subsystem maintainer. Simon