Re: [PATCH] gdb/dwarf: rename dwarf2_per_cu_data -> dwarf2_per_cu

[Simon Marchi <simon.marchi@polymtl.ca>]

On 3/3/25 3:32 PM, Tom Tromey wrote:
>>>>>> "simon" == simon marchi <simon.marchi@polymtl.ca> writes:
> 
> Simon> This scratches an itch I had for a while.  I don't know why this struct
> Simon> type has "data" in its name.  Others like "dwarf2_per_objfile" and
> Simon> "dwarf2_per_bfd" don't.  The primary job of a structure is to hold data,
> Simon> there's no need to specify it.  It also makes the name a bit shorter,
> Simon> which is always nice.
> 
> It's fine by me but I wonder if this is really the best final naming, as
> now we have dwarf2_cu and dwarf2_per_cu.

At least, dwarf2_per_cu is consistent with dwarf2_per_objfile and
dwarf2_per_bfd, and first nicely in the "dwarf2_per_objfile ->
dwarf2_per_bfd -> dwarf2_per_cu" hierarchy.

If I had to rename one, I would probably rename "dwarf2_cu", but I don't
know to what, because I have a hard time expressing what it is exactly.
Anyway, even if dwarf2_per_cu changes again in the future, I don't think
it's the end of the world to have this intermediary step.

> Approved-By: Tom Tromey <tom@tromey.com>

Thanks, will push.

Simon