From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id HPXiDWEXxmf0FwQAWB0awg (envelope-from ) for ; Mon, 03 Mar 2025 15:56:01 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=default header.b=dNlWiic3; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 26C2A1E105; Mon, 3 Mar 2025 15:56:01 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=unavailable autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id BC7941E05C for ; Mon, 3 Mar 2025 15:56:00 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5CC9F3858D26 for ; Mon, 3 Mar 2025 20:56:00 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5CC9F3858D26 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=default header.b=dNlWiic3 Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 57055385840F for ; Mon, 3 Mar 2025 20:55:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 57055385840F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=polymtl.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=polymtl.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 57055385840F Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=132.207.4.11 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1741035328; cv=none; b=CBWNXNUhj7QDs84aIpotMecKrU6agYud00dJv0SdGqYAEKDYW8uJZp8ImYO7wqptFN2ELMZ5VcLJ4KWPxaM4W+8/mjF79OJNYg0Gw5/jwrR0lJ6VaxGGc1vibocIHixLsLm5VzjjCFkgbBYre+eNuEKqvzXaRkzu82udfivbjAU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1741035328; c=relaxed/simple; bh=K4OuprAJ6Zgf+mJ50aRU2fsMjd+Mz14tOXABnAvuAZA=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=ZI4PvbgsP9KmZ6J90mGYez6/vmcFQtZRagOutb5JHvFJ8WM0RnvttwgxbZx6+rvi4F+w6pd3eaL5mehT69IkRO3Q+mhrcZa+VLz+F9xm8ggNn4M6UuwtQ0cyE2VCemdDfp8hKIZy9veCMrdBpYwHjALXOP7Z7guvhQ+fJfPAES0= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 57055385840F Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 523KtNwf094454 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 3 Mar 2025 15:55:27 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 523KtNwf094454 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=default; t=1741035327; bh=KYf4LeygceAoYXN1zEvozjTjJQWF4JCASTKKnbGiFm4=; h=Date:Subject:To:Cc:From:In-Reply-To:From; b=dNlWiic3AARU0XvlvEY32gbqPgm1laxJTEJvpWos4pSf7DAvY1GhkMBtzF7P9mb47 panCsqtl5kSutWSRduAy8NDNCHMptjB2EjhsQiWubryhvBj77TNEhVGWZy2hCs1ETj HFM1uolB31zQl6ITxG1PMWyD5K1iJhA3KF+Oz3dU= Received: by simark.ca (Postfix, from userid 112) id 17E3E1E110; Mon, 3 Mar 2025 15:55:23 -0500 (EST) Received: from [172.16.0.192] (96-127-217-162.qc.cable.ebox.net [96.127.217.162]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id BA4881E05C; Mon, 3 Mar 2025 15:55:21 -0500 (EST) Message-ID: <9003f9b2-dc1d-421d-bb85-1a62daf1b7e4@polymtl.ca> Date: Mon, 3 Mar 2025 15:55:21 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gdb/dwarf: rename dwarf2_per_cu_data -> dwarf2_per_cu To: Tom Tromey Cc: gdb-patches@sourceware.org, Simon Marchi References: <20250226042042.2267150-1-simon.marchi@polymtl.ca> <87mse13lf1.fsf@tromey.com> Content-Language: fr From: Simon Marchi In-Reply-To: <87mse13lf1.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Mon, 3 Mar 2025 20:55:23 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 3/3/25 3:32 PM, Tom Tromey wrote: >>>>>> "simon" == simon marchi writes: > > Simon> This scratches an itch I had for a while. I don't know why this struct > Simon> type has "data" in its name. Others like "dwarf2_per_objfile" and > Simon> "dwarf2_per_bfd" don't. The primary job of a structure is to hold data, > Simon> there's no need to specify it. It also makes the name a bit shorter, > Simon> which is always nice. > > It's fine by me but I wonder if this is really the best final naming, as > now we have dwarf2_cu and dwarf2_per_cu. At least, dwarf2_per_cu is consistent with dwarf2_per_objfile and dwarf2_per_bfd, and first nicely in the "dwarf2_per_objfile -> dwarf2_per_bfd -> dwarf2_per_cu" hierarchy. If I had to rename one, I would probably rename "dwarf2_cu", but I don't know to what, because I have a hard time expressing what it is exactly. Anyway, even if dwarf2_per_cu changes again in the future, I don't think it's the end of the world to have this intermediary step. > Approved-By: Tom Tromey Thanks, will push. Simon