From: "Eli Zaretskii" <eliz@elta.co.il>
To: Andrew Cagney <cagney@gnu.org>
Cc: carlton@kealia.com, gdb-patches@sources.redhat.com
Subject: Re: [commit] Deprecate remaining STREQ uses
Date: Tue, 25 Nov 2003 19:14:00 -0000 [thread overview]
Message-ID: <9743-Tue25Nov2003211147+0200-eliz@elta.co.il> (raw)
In-Reply-To: <3FC39747.2090007@gnu.org> (message from Andrew Cagney on Tue, 25 Nov 2003 12:54:15 -0500)
> Date: Tue, 25 Nov 2003 12:54:15 -0500
> From: Andrew Cagney <cagney@gnu.org>
> >
> > Actually, in the case at hand, they would give different results, it
> > turns out! The definition of STREQ isn't simply strcmp()==0 - there's
> > an optimization (or "optimization", perhaps) there as well.
>
> You'll now appreciate my paranoia :-)
So does Emacs ;-)
> So, should the transformation be the strictly mechanical inline expansion:
>
> STREQ(a,b) => (*(a) == *(b) ? !strcmp ((a), (b)) : 0)
>
> or also include a simplification leading to:
>
> STREQ(a,b) => (strcmp ((a), (b)) == 0)
IIRC, we decided long ago that the so-called ``optimization'' in the
former macro definition was a waste of cycles. So my recommendation
would be to use the latter.
next prev parent reply other threads:[~2003-11-25 19:14 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-11-23 21:08 Andrew Cagney
2003-11-24 5:57 ` Eli Zaretskii
2003-11-24 16:41 ` Andrew Cagney
2003-11-24 16:50 ` Daniel Jacobowitz
2003-11-24 18:02 ` David Carlton
2003-11-24 19:36 ` Eli Zaretskii
2003-11-24 18:25 ` Kevin Buettner
2003-11-24 20:03 ` Andrew Cagney
2003-11-25 0:09 ` Kevin Buettner
2003-11-27 14:30 ` Andrew Cagney
2003-11-27 17:27 ` Eli Zaretskii
2003-12-01 15:47 ` Andrew Cagney
2003-12-01 19:08 ` Eli Zaretskii
2003-12-01 19:17 ` Daniel Jacobowitz
2003-12-01 19:22 ` Joel Brobecker
2003-12-01 21:25 ` Andrew Cagney
2003-12-01 21:32 ` Daniel Jacobowitz
2003-12-03 3:47 ` Andrew Cagney
2003-12-03 16:37 ` Andrew Cagney
2003-12-01 19:40 ` Andrew Cagney
2003-12-04 4:44 ` Kevin Buettner
2003-12-04 15:45 ` Eli Zaretskii
2003-12-04 17:33 ` Andrew Cagney
2003-12-05 16:14 ` Eli Zaretskii
2003-12-12 19:26 ` Kevin Buettner
2003-12-13 1:01 ` Andrew Cagney
2003-11-24 20:32 ` Andrew Cagney
2003-11-24 23:56 ` Kevin Buettner
2003-11-25 1:33 ` Andrew Cagney
2003-11-25 6:51 ` Eli Zaretskii
2003-12-04 4:21 ` Kevin Buettner
2003-11-24 19:33 ` Eli Zaretskii
2003-11-24 19:58 ` Andrew Cagney
2003-11-24 21:06 ` Joel Brobecker
2003-11-26 20:54 ` Andrew Cagney
2003-11-25 6:56 ` Eli Zaretskii
2003-11-24 19:36 ` Andrew Cagney
2003-11-24 20:54 ` Daniel Jacobowitz
2003-11-24 22:08 ` Andrew Cagney
2003-11-24 19:24 ` Eli Zaretskii
2003-11-24 19:45 ` Andrew Cagney
2003-11-25 6:58 ` Eli Zaretskii
2003-11-24 20:06 ` David Carlton
2003-11-25 6:54 ` Eli Zaretskii
2003-11-25 16:59 ` David Carlton
2003-11-25 17:54 ` Andrew Cagney
2003-11-25 17:57 ` Daniel Jacobowitz
2003-11-25 17:59 ` David Carlton
2003-11-25 18:42 ` Andrew Cagney
2003-11-25 19:21 ` Eli Zaretskii
2003-11-25 17:58 ` David Carlton
2003-11-25 18:02 ` Kevin Buettner
2003-11-25 19:14 ` Eli Zaretskii [this message]
2003-12-05 16:26 ` Andrew Cagney
2003-12-05 17:56 ` Eli Zaretskii
2003-12-06 14:09 ` Andrew Cagney
2003-12-06 15:23 ` Eli Zaretskii
2003-12-07 15:54 ` Andrew Cagney
2003-11-24 17:48 Michael Elizabeth Chastain
2003-12-03 5:05 Michael Elizabeth Chastain
2003-12-12 19:49 Michael Elizabeth Chastain
2003-12-13 10:18 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9743-Tue25Nov2003211147+0200-eliz@elta.co.il \
--to=eliz@elta.co.il \
--cc=cagney@gnu.org \
--cc=carlton@kealia.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox