From: Kevin Buettner <kevinb@redhat.com>
To: Andrew Cagney <cagney@gnu.org>, Kevin Buettner <kevinb@redhat.com>
Cc: Daniel Jacobowitz <drow@mvista.com>, gdb-patches@sources.redhat.com
Subject: Re: [commit] Deprecate remaining STREQ uses
Date: Tue, 25 Nov 2003 00:09:00 -0000 [thread overview]
Message-ID: <1031125000932.ZM11256@localhost.localdomain> (raw)
In-Reply-To: Andrew Cagney <cagney@gnu.org> "Re: [commit] Deprecate remaining STREQ uses" (Nov 24, 3:03pm)
On Nov 24, 3:03pm, Andrew Cagney wrote:
> > IMO, it should be possible to convert uses of STREQ/STREQN without
> > much risk.
>
> To speak from experience, I found 'n' fixed errors in even the existing
> conversions. You'll note that some of the mamoth conversions that
> you've done in the past also had similar problems.
True. I do recall having to fix problems in the code prior to starting
a conversion.
> Anyway, Eli's pointed me at an automated tool for finishing the task.
Automated tools are good. (I figured you already had most of it
automated...)
Even if the process isn't entirely automated, it's still sometimes
better to do the conversion all at once. By deprecating something,
you're forcing someone else (or even a later version of yourself) to
deal with the problem later on. Chances are good that the person
making the changes understand the issues surrounding the change a lot
better than someone coming at it cold later on. Also, doing it all at
once will (hopefully) ensure that the changes in question are done in
a uniform manner.
Kevin
next prev parent reply other threads:[~2003-11-25 0:09 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-11-23 21:08 Andrew Cagney
2003-11-24 5:57 ` Eli Zaretskii
2003-11-24 16:41 ` Andrew Cagney
2003-11-24 16:50 ` Daniel Jacobowitz
2003-11-24 18:02 ` David Carlton
2003-11-24 19:36 ` Eli Zaretskii
2003-11-24 18:25 ` Kevin Buettner
2003-11-24 20:03 ` Andrew Cagney
2003-11-25 0:09 ` Kevin Buettner [this message]
2003-11-27 14:30 ` Andrew Cagney
2003-11-27 17:27 ` Eli Zaretskii
2003-12-01 15:47 ` Andrew Cagney
2003-12-01 19:08 ` Eli Zaretskii
2003-12-01 19:17 ` Daniel Jacobowitz
2003-12-01 19:22 ` Joel Brobecker
2003-12-01 21:25 ` Andrew Cagney
2003-12-01 21:32 ` Daniel Jacobowitz
2003-12-03 3:47 ` Andrew Cagney
2003-12-03 16:37 ` Andrew Cagney
2003-12-01 19:40 ` Andrew Cagney
2003-12-04 4:44 ` Kevin Buettner
2003-12-04 15:45 ` Eli Zaretskii
2003-12-04 17:33 ` Andrew Cagney
2003-12-05 16:14 ` Eli Zaretskii
2003-12-12 19:26 ` Kevin Buettner
2003-12-13 1:01 ` Andrew Cagney
2003-11-24 20:32 ` Andrew Cagney
2003-11-24 23:56 ` Kevin Buettner
2003-11-25 1:33 ` Andrew Cagney
2003-11-25 6:51 ` Eli Zaretskii
2003-12-04 4:21 ` Kevin Buettner
2003-11-24 19:33 ` Eli Zaretskii
2003-11-24 19:58 ` Andrew Cagney
2003-11-24 21:06 ` Joel Brobecker
2003-11-26 20:54 ` Andrew Cagney
2003-11-25 6:56 ` Eli Zaretskii
2003-11-24 19:36 ` Andrew Cagney
2003-11-24 20:54 ` Daniel Jacobowitz
2003-11-24 22:08 ` Andrew Cagney
2003-11-24 19:24 ` Eli Zaretskii
2003-11-24 19:45 ` Andrew Cagney
2003-11-25 6:58 ` Eli Zaretskii
2003-11-24 20:06 ` David Carlton
2003-11-25 6:54 ` Eli Zaretskii
2003-11-25 16:59 ` David Carlton
2003-11-25 17:54 ` Andrew Cagney
2003-11-25 17:57 ` Daniel Jacobowitz
2003-11-25 17:59 ` David Carlton
2003-11-25 18:42 ` Andrew Cagney
2003-11-25 19:21 ` Eli Zaretskii
2003-11-25 17:58 ` David Carlton
2003-11-25 18:02 ` Kevin Buettner
2003-11-25 19:14 ` Eli Zaretskii
2003-12-05 16:26 ` Andrew Cagney
2003-12-05 17:56 ` Eli Zaretskii
2003-12-06 14:09 ` Andrew Cagney
2003-12-06 15:23 ` Eli Zaretskii
2003-12-07 15:54 ` Andrew Cagney
2003-11-24 17:48 Michael Elizabeth Chastain
2003-12-03 5:05 Michael Elizabeth Chastain
2003-12-12 19:49 Michael Elizabeth Chastain
2003-12-13 10:18 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1031125000932.ZM11256@localhost.localdomain \
--to=kevinb@redhat.com \
--cc=cagney@gnu.org \
--cc=drow@mvista.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox