Re: [PATCH 0/5] Improved support for core files with missing NT_FILE note

[Keith Seitz <keiths@redhat.com>]

Hi,

On 3/14/26 7:32 AM, Andrew Burgess wrote:
> This series improves GDB's support for core files without an NT_FILE
> note.  When this note is missing GDB is currently unable to associate
> a build-id with any of the shared libraries that loaded as the core
> file is opened.  As a result GDB might load the wrong shared library
> if a local library happens to have the same name (e.g. is a different
> version of the same library), and GDB will not perform a build-id
> based lookup either locally, or through debuginfod, for the missing
> shared library.
> 
> Patches #1 and #2 rework some existing tests.  This gets these tests
> into a state where they can be reused for testing the fixes that come
> later in the series.
> 
> Patches #3 and #4 are minor refactoring patches removing some code
> that will make the later patch in this series harder.

These all look okay to me, and one or two are even pretty obvious.

> Patch #5 is the actual fix.  After this, on GNU/Linux, GDB will be
> able to associate a build-id with a shared library, even if the
> NT_FILE note is missing from a core file.

I will follow-up with a correction in this patch, but otherwise,
everything appears okay.

FWIW, I regression tested this internally on all supported
architectures on F43 and found nothing.

Reviewed-By: Keith Seitz <keiths@redhat.com>

Keith