From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id jJj+NRKY6mmGcTcAWB0awg (envelope-from ) for ; Thu, 23 Apr 2026 18:07:14 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=FBvpAAXQ; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id CA8391E0BA; Thu, 23 Apr 2026 18:07:14 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id E800F1E093 for ; Thu, 23 Apr 2026 18:07:13 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 86E5C4B99F5A for ; Thu, 23 Apr 2026 22:07:12 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 86E5C4B99F5A Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=FBvpAAXQ Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id E60A14BAD14E for ; Thu, 23 Apr 2026 22:06:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E60A14BAD14E Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E60A14BAD14E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776982008; cv=none; b=Uf7QTzY4WnJOddekOKuMsY6rJ95zGyuvMx4uHBXsxFaz8p3kFX1+kStXe6DhVggV8NEzPy2+uuhvHD4Te0l7Az45cday5fDvNwo3ivsFmwJxL9j92KRH5vPKRNGVg2ZWgU106c9CIk47GqpY5dOXmkAUo2PeYl7Bj89L9F4NzQc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776982008; c=relaxed/simple; bh=P9pQts4DFFeh5Kk8HAvnQjg9b3Z+TtzuIFFqzx+JeU4=; h=DKIM-Signature:Message-ID:Date:MIME-Version:From:Subject:To; b=cpkZa8CAZSqvtWOrUU6/yXudfwjXk8lwc9g7OawHgBHO0BLQnkYbWMwybSrGeDE84DQqvdbxZ6ncVQkAH96CN/jPKT1O09fX/CVb9xdFRpvtaJSB3QtlGDrJs5QknZSayFDMz3mO/xwkHnq5VB6+pJI1oLbv04xQswynDQuI5/M= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E60A14BAD14E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1776982007; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MtUr+EYVutmK+CvYieqQPWFBUwWzJTr0p39T/29vzn0=; b=FBvpAAXQ02Pp1l8wEbQG/UrqQx444UIMkNlwliBwW1ftJ6bccetZGy1uhhDG3LeRTlDbgd fl4i8h45YrzGiexP1UhLvAP9Q2xbQPKIEuHWPGg5Pz0ZSLfQbs4uGDByx5tMmP0oltwiOe 88UNj/qUJFm/rmdlgUdebWaRngT2tBc= Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-682-M5qg24hyMAq-_hlhGXBV-g-1; Thu, 23 Apr 2026 18:06:46 -0400 X-MC-Unique: M5qg24hyMAq-_hlhGXBV-g-1 X-Mimecast-MFC-AGG-ID: M5qg24hyMAq-_hlhGXBV-g_1776982006 Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-50edf0245b0so107047261cf.1 for ; Thu, 23 Apr 2026 15:06:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776982005; x=1777586805; h=content-transfer-encoding:in-reply-to:content-language:references :to:subject:from:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=MtUr+EYVutmK+CvYieqQPWFBUwWzJTr0p39T/29vzn0=; b=e1cvIsUzQe0wRE4OajeY1hAZNESoZgxIPlDcSkzYS9AAvfKrn0Vgef0Wfd52e9xP7I Q81wAxvuVdh/rWZ46Q48MnUGetYSknrpXmmXrt83a5iG/AkCB7sldKjpW1WmUnTs7MSR M2IWiYlp+KhHU5TV7KcJpCGqr8QqlM3tXij+Wkh1wbldB3xj47g2nBovKqgfdjZtyM9j 5n+WtUrWrVeZexfDIGbaHVnRBb5PA/poxrQso/KLZFqHj9NQgbKbA+dzbKgZCCVe6B7i ETHsWtacjpmGXIdITBDQiOzZwom7/d2aGR42kqS469dRT984iayxTNdcd7Ctd0xnnPpu urQw== X-Forwarded-Encrypted: i=1; AFNElJ+6sQy6Me9fGKqG6LcBB0Qwn9nXvdfIQp7oKS0O9u4kdTLJ64qRsYv6c8KbQzNYORZ0RbxKyI3wpGu99Q==@sourceware.org X-Gm-Message-State: AOJu0YxTcaOfds0S89r2s8+v6bRd6v4NYUYOFdDdzwuOTeiOQoOJNNSQ zItkQ5oTw69etxO16KOQ/KsWOkKDGAoJGlAU1t3F6sEA72thIGRXvKYx+62FYm6tY6QKAMYRWrp ctjm4D+/PwXkNNO+MJhtRjGI4NT1LOWRncfrFpWzDbj+awRHNde7VA5c90fRzxtE/AmwDUPM= X-Gm-Gg: AeBDiesgmPEwXT51feZYG6Kujkvk8tXDqTd/DI92DIza73Nts/C2SNrow4yrSSW/sQH oigWhg80iDN8i+PEY1TuupGdXV7xQTokXM/u336FcKCw07+V2jW2eh489ldoMjD1JEaMQ77uJGV 4aaz8HLhK5yRLLFo4iqFqQxECiBhkdQQu88ayOhqrUX/s+zFY6bd61K2Lxhmdnf0rGhuWH3wS4m HxEo+5JQ9CJA0m4O21wf/46U4Th4O7ubNCza6YxrnU2hJjHw8Hq9kJ83Zhxp45ZPqsM8TyR+0H+ vRGCISUJ+PdGPdT97pGUZuRUKS6RuqLBLotc+Cyry+cD2eljdocpk8g8OYRmV3Iv7gXqe3p4mZX dymExA/FWsRBiIBScO0K2x8HKyYR1qMKWwaIDLMo= X-Received: by 2002:a05:622a:8a04:b0:50e:5aed:caf3 with SMTP id d75a77b69052e-50e5aedccd7mr196808611cf.9.1776982004694; Thu, 23 Apr 2026 15:06:44 -0700 (PDT) X-Received: by 2002:a05:622a:8a04:b0:50e:5aed:caf3 with SMTP id d75a77b69052e-50e5aedccd7mr196808351cf.9.1776982004259; Thu, 23 Apr 2026 15:06:44 -0700 (PDT) Received: from [150.1.200.157] ([172.56.107.181]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8b02ac78513sm170084696d6.19.2026.04.23.15.06.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Apr 2026 15:06:43 -0700 (PDT) Message-ID: <95f4e7d3-d9c2-439a-a190-4ba4e9d0eeda@redhat.com> Date: Thu, 23 Apr 2026 15:06:41 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Keith Seitz Subject: Re: [PATCH 0/5] Improved support for core files with missing NT_FILE note To: Andrew Burgess , gdb-patches@sourceware.org References: In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Bv2Sk3VWkmLjN8BMr4g2FzyBODqDtUwPYRnTONzanDE_1776982006 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Hi, On 3/14/26 7:32 AM, Andrew Burgess wrote: > This series improves GDB's support for core files without an NT_FILE > note. When this note is missing GDB is currently unable to associate > a build-id with any of the shared libraries that loaded as the core > file is opened. As a result GDB might load the wrong shared library > if a local library happens to have the same name (e.g. is a different > version of the same library), and GDB will not perform a build-id > based lookup either locally, or through debuginfod, for the missing > shared library. > > Patches #1 and #2 rework some existing tests. This gets these tests > into a state where they can be reused for testing the fixes that come > later in the series. > > Patches #3 and #4 are minor refactoring patches removing some code > that will make the later patch in this series harder. These all look okay to me, and one or two are even pretty obvious. > Patch #5 is the actual fix. After this, on GNU/Linux, GDB will be > able to associate a build-id with a shared library, even if the > NT_FILE note is missing from a core file. I will follow-up with a correction in this patch, but otherwise, everything appears okay. FWIW, I regression tested this internally on all supported architectures on F43 and found nothing. Reviewed-By: Keith Seitz Keith