Re: [PATCH 5/5] gdb/linux: handle missing NT_FILE note when opening core files

[Keith Seitz <keiths@redhat.com>]

On 3/14/26 7:32 AM, Andrew Burgess wrote:
> Then in corelow.c various functions are updated in order to handle
> anonymous mappings.

Just one note below, otherwise LGTM.

> diff --git a/gdb/corelow.c b/gdb/corelow.c
> index d63dd5f8f0d..d1412c4903a 100644
> --- a/gdb/corelow.c
> +++ b/gdb/corelow.c
> @@ -1963,7 +1972,6 @@ mapped_file_info::add (const char *soname,
>   		       const bfd_build_id *build_id)
>   {
>     gdb_assert (build_id != nullptr);
> -  gdb_assert (expected_filename != nullptr);
>   
>     if (soname != nullptr)
>       {

The comment at the beginning of this method (mapped_file_info::add)
contains:

    EXPECTED_FILENAME is the name of the file that was mapped into the
    inferior as extracted from the core file, this should never be
    nullptr.

This needs to be updated, since null `expected_filename' file names
will now be ignored.

Keith

> @@ -1983,13 +1991,17 @@ mapped_file_info::add (const char *soname,
>   	m_soname_to_build_id_map[soname] = build_id;
>       }
>   
> -  /* When the core file is initially opened and the mapped files are
> -     parsed, we group the build-id information based on the file name.  As
> -     a consequence, we should see each EXPECTED_FILENAME value exactly
> -     once.  This means that each insertion should always succeed.  */
> -  const auto inserted
> -    = m_filename_to_build_id_map.emplace (expected_filename, build_id).second;
> -  gdb_assert (inserted);
> +  /* Ignore empty filenames.  */
> +  if (expected_filename != nullptr)
> +    {
> +      /* When the core file is initially opened and the mapped files are
> +	 parsed, we group the build-id information based on the file name.  As
> +	 a consequence, we should see each EXPECTED_FILENAME value exactly
> +	 once.  This means that each insertion should always succeed.  */
> +      const auto inserted
> +	= m_filename_to_build_id_map.emplace (expected_filename, build_id).second;
> +      gdb_assert (inserted);
> +    }
>   
>     /* Setup the reverse build-id to file name map.  */
>     if (actual_filename != nullptr)