Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Simon Marchi <simark@simark.ca>
To: Kevin Buettner <kevinb@redhat.com>,
	Simon Marchi <simon.marchi@efficios.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb: rename address_class -> location_class
Date: Tue, 19 Aug 2025 09:59:22 -0400	[thread overview]
Message-ID: <95a6c0ba-5ef5-4bac-b54f-7650fe70292a@simark.ca> (raw)
In-Reply-To: <20250815195911.5c352dcc@f41-zbm-amd>

On 8/15/25 10:59 PM, Kevin Buettner wrote:
> On Thu, 14 Aug 2025 16:14:06 -0400
> Simon Marchi <simon.marchi@efficios.com> wrote:
> 
>> The enum address_class and related fields and methods seem misnamed to
>> me.  Generalize it to "location_class".  The enumerators in
>> address_class are already prefixed with LOC, so the new name seems
>> logical to me.  Rename related fields and methods as well.
>>
>> Plus, address_class could easily be mistaken for other unrelated things
>> named "address class" in GDB or DWARF.
>>
>> Tested by rebuilding.
> 
> I agree that "location class" makes more sense.
> 
> Approved-by: Kevin Buettner <kevinb@redhat.com>
> 

Thanks, pushed.

Simon

      reply	other threads:[~2025-08-19 14:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-14 20:14 Simon Marchi
2025-08-16  2:59 ` Kevin Buettner
2025-08-19 13:59   ` Simon Marchi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=95a6c0ba-5ef5-4bac-b54f-7650fe70292a@simark.ca \
    --to=simark@simark.ca \
    --cc=gdb-patches@sourceware.org \
    --cc=kevinb@redhat.com \
    --cc=simon.marchi@efficios.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox