From: Kevin Buettner <kevinb@redhat.com>
To: Simon Marchi <simon.marchi@efficios.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb: rename address_class -> location_class
Date: Fri, 15 Aug 2025 19:59:11 -0700 [thread overview]
Message-ID: <20250815195911.5c352dcc@f41-zbm-amd> (raw)
In-Reply-To: <20250814201407.163899-1-simon.marchi@efficios.com>
On Thu, 14 Aug 2025 16:14:06 -0400
Simon Marchi <simon.marchi@efficios.com> wrote:
> The enum address_class and related fields and methods seem misnamed to
> me. Generalize it to "location_class". The enumerators in
> address_class are already prefixed with LOC, so the new name seems
> logical to me. Rename related fields and methods as well.
>
> Plus, address_class could easily be mistaken for other unrelated things
> named "address class" in GDB or DWARF.
>
> Tested by rebuilding.
I agree that "location class" makes more sense.
Approved-by: Kevin Buettner <kevinb@redhat.com>
next prev parent reply other threads:[~2025-08-16 3:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-14 20:14 Simon Marchi
2025-08-16 2:59 ` Kevin Buettner [this message]
2025-08-19 13:59 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250815195911.5c352dcc@f41-zbm-amd \
--to=kevinb@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@efficios.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox