From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id c7ypIj30n2jdlQQAWB0awg (envelope-from ) for ; Fri, 15 Aug 2025 23:00:13 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=YJuAwOAd; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 7D00E1E08D; Fri, 15 Aug 2025 23:00:13 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id D84B71E08D for ; Fri, 15 Aug 2025 23:00:08 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 516563858D32 for ; Sat, 16 Aug 2025 03:00:08 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 516563858D32 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=YJuAwOAd Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 3B9CE3858D1E for ; Sat, 16 Aug 2025 02:59:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3B9CE3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3B9CE3858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1755313159; cv=none; b=kaz0jkNuXiixbcUcNaoZCd4MsLNNFeYqn/k1WMAPsYbjmFCQ+L59LS0V+DhdC5aDKeWPToR3AAEtyZlkaUL/ZRRPWv3kdu87RI3S972/voW84IYnOcif52HLcGX7mUT28Xk90Nqwey8f9wB8nE5pjQeooDYCxsHRC3uZUyKqrrE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1755313159; c=relaxed/simple; bh=F9w3o1YDLQn3B7jmKz37ljaJNqO2KsKcV8mJDMlKxaE=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=ElR6PEh6zRXZ//h/plW1zE8ANFpiJBBkRY3tA4IAKblEusC4XNZe6RysFeGiOTX47RPAtCRqhY2Q1Rm3eCTU27bjcL1f1uoa1Kxoi2Jniw0E06hhOtbLzSGfNQDqJxEeIETW3EJvYG11HMS3ZGffTfJvSF/GhDZ+HCS79DeGSLo= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3B9CE3858D1E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1755313159; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eCWsrSg5wsAtgGbO1rqxndVkQ3NGUPeaoHxSqQoupl4=; b=YJuAwOAduARCO9QCDru0PVmw7KbFh4h1YWEBrJOFgosR5Q2/5BK+sjMhzRU2guoy2cq4+Q ECS10bdEQTCDyE/gjyGr7TL77t+NZHgIDbJL1uhHX+L6RmeiV3h0uR9kRgfdBR4R/Sjb0N e2xGA1xygcLwjruVr6JEtpPwZsRHMUw= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-618-HnpIqq4ZPlaMzpR1tR2HBA-1; Fri, 15 Aug 2025 22:59:17 -0400 X-MC-Unique: HnpIqq4ZPlaMzpR1tR2HBA-1 X-Mimecast-MFC-AGG-ID: HnpIqq4ZPlaMzpR1tR2HBA_1755313156 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 52E1C18003FC; Sat, 16 Aug 2025 02:59:16 +0000 (UTC) Received: from f41-zbm-amd (unknown [10.22.88.20]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 76ADF180047F; Sat, 16 Aug 2025 02:59:15 +0000 (UTC) Date: Fri, 15 Aug 2025 19:59:11 -0700 From: Kevin Buettner To: Simon Marchi Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] gdb: rename address_class -> location_class Message-ID: <20250815195911.5c352dcc@f41-zbm-amd> In-Reply-To: <20250814201407.163899-1-simon.marchi@efficios.com> References: <20250814201407.163899-1-simon.marchi@efficios.com> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: fc6wbf4HewUpk69oaD0YDFPVIM6X31935tmV5boFhoI_1755313156 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On Thu, 14 Aug 2025 16:14:06 -0400 Simon Marchi wrote: > The enum address_class and related fields and methods seem misnamed to > me. Generalize it to "location_class". The enumerators in > address_class are already prefixed with LOC, so the new name seems > logical to me. Rename related fields and methods as well. > > Plus, address_class could easily be mistaken for other unrelated things > named "address class" in GDB or DWARF. > > Tested by rebuilding. I agree that "location class" makes more sense. Approved-by: Kevin Buettner