From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id sUKeD2SDpGj7EAcAWB0awg (envelope-from ) for ; Tue, 19 Aug 2025 10:00:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1755612004; bh=qwkqo7JzFfzbM5ztOdUte2YKJSlXrPn7TauV5TNT0UU=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=M6RPr4KZ9kyyg4wJeyxYyVNcrOcjMR3Rluoh1xQdvslrIZLivZ3gqfSEXvyppRoqy i02r2p8hFRBcc9US36NNcD/jC4wIKglVzBf0LbAqL+L9a/zFj+BbZjdo9HFj9aK1nl ygthBbydKqWGFkfWNVOSDTk8FlcNOcQ5lQDNLHy4= Received: by simark.ca (Postfix, from userid 112) id 3213B1E0B3; Tue, 19 Aug 2025 10:00:04 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_LOW,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=no autolearn_force=no version=4.0.1 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=KS6YoJZY; dkim-atps=neutral Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 13D641E047 for ; Tue, 19 Aug 2025 10:00:00 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A6EB9385DC1B for ; Tue, 19 Aug 2025 13:59:59 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A6EB9385DC1B Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=KS6YoJZY Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 85E643854816 for ; Tue, 19 Aug 2025 13:59:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 85E643854816 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 85E643854816 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1755611963; cv=none; b=BunGGu56HcOiiERydMU8jHv/tOSQV+JC+dmqtmaiQj3Tn//HhLLYnZ7vU+L0pryhyIOpQTB0C2D1FYIs7tQTcAu4AsCmvwaE9752Y5pri8iCnHpfTRFfdoc3xTdQ/ifyjr55qHY3LmddULTmr1TJyOT9TUBfhS44rdUAXVdIl1U= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1755611963; c=relaxed/simple; bh=qwkqo7JzFfzbM5ztOdUte2YKJSlXrPn7TauV5TNT0UU=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=ul7DQmFc+678K5Ns9VFWxq5/7xLhA2Pcmx+bc2VuCgeCauZfGsTwjeWYNGotih/rz8IGZ2158MR4mk9FPU6taC05I5XRfjhsEitPSrW6vzLE96Tfuuwo5v4NCpWhEdmirKk9qEyAALOZ+yzb9rOr0nu+q0bqbFqGg+IoH1IP+DM= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 85E643854816 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1755611963; bh=qwkqo7JzFfzbM5ztOdUte2YKJSlXrPn7TauV5TNT0UU=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=KS6YoJZYXQydoSWj1zMl5T/kzhjLF2IpTQ2BflduIWnr7mK97WW5q3qM1dcCTJpgH 9i+8PwcaAaRPryzeGbJkbjbeGX5mhUudHtnN9VnxArlcVvNCW3pd+B1BHeny8/5gIJ Lgz/dGoT1DTU6BZIyzCqDYaQskn2WDpPJW9Oom/4= Received: by simark.ca (Postfix) id 1421C1E047; Tue, 19 Aug 2025 09:59:23 -0400 (EDT) Message-ID: <95a6c0ba-5ef5-4bac-b54f-7650fe70292a@simark.ca> Date: Tue, 19 Aug 2025 09:59:22 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gdb: rename address_class -> location_class To: Kevin Buettner , Simon Marchi Cc: gdb-patches@sourceware.org References: <20250814201407.163899-1-simon.marchi@efficios.com> <20250815195911.5c352dcc@f41-zbm-amd> Content-Language: fr From: Simon Marchi In-Reply-To: <20250815195911.5c352dcc@f41-zbm-amd> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 8/15/25 10:59 PM, Kevin Buettner wrote: > On Thu, 14 Aug 2025 16:14:06 -0400 > Simon Marchi wrote: > >> The enum address_class and related fields and methods seem misnamed to >> me. Generalize it to "location_class". The enumerators in >> address_class are already prefixed with LOC, so the new name seems >> logical to me. Rename related fields and methods as well. >> >> Plus, address_class could easily be mistaken for other unrelated things >> named "address class" in GDB or DWARF. >> >> Tested by rebuilding. > > I agree that "location class" makes more sense. > > Approved-by: Kevin Buettner > Thanks, pushed. Simon